Issue 5784049: A new templated static method Ipv4RoutingHelper::GetRouting that allows search for any routing prot…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5784049: A new templated static method Ipv4RoutingHelper::GetRouting that allows search for any routing prot… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by Frederic U

Modified:
12 years, 1 month ago

Reviewers:
Tommaso Pecorella

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

More Reviews

Description

A new templated static method Ipv4RoutingHelper::GetRouting that allows search for any routing prot…

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -13 lines)			Patch
M	src/internet/helper/ipv4-routing-helper.h	View	2 chunks	+31 lines, -0 lines	0 comments	Download
M	src/internet/model/ipv4-l3-protocol.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/internet/model/ipv4-raw-socket-impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/internet/model/ipv4-static-routing.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/internet/model/ipv4-static-routing.cc	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	src/internet/model/ipv6-raw-socket-impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/internet/model/udp-socket-impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/network/model/socket.h	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	src/network/model/socket.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Tommaso Pecorella

12 years, 1 month ago (2012-03-08 13:20:56 UTC) #1

Some changes are from a different patch, plus there is no clear evidence of the
proposed new API use.
The changes in StaticRouting have no connection with the new API from the
Helper.

Please remove the non-relevant changes and explain better the rationale of the
remaining changes.

T.

Expand All Messages | Collapse All Messages