Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 5784049: A new templated static method Ipv4RoutingHelper::GetRouting that allows search for any routing prot… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by Frederic U
Modified:
10 years, 8 months ago
Reviewers:
Tommaso Pecorella
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

A new templated static method Ipv4RoutingHelper::GetRouting that allows search for any routing prot…

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -13 lines) Patch
M src/internet/helper/ipv4-routing-helper.h View 2 chunks +31 lines, -0 lines 0 comments Download
M src/internet/model/ipv4-l3-protocol.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/internet/model/ipv4-raw-socket-impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/ipv4-static-routing.h View 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/ipv4-static-routing.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/internet/model/ipv6-raw-socket-impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/udp-socket-impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/network/model/socket.h View 2 chunks +11 lines, -1 line 0 comments Download
M src/network/model/socket.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 1
Tommaso Pecorella
10 years, 8 months ago (2012-03-08 13:20:56 UTC) #1
Some changes are from a different patch, plus there is no clear evidence of the
proposed new API use.
The changes in StaticRouting have no connection with the new API from the
Helper.

Please remove the non-relevant changes and explain better the rationale of the
remaining changes.

T.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b