Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(128)

Issue 5777044: Puts an allowed range on z-index. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by metaweta
Modified:
14 years, 3 months ago
Reviewers:
felix8a, Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Allows -1E6 to 1E6 as valid z-indices. We reserve the values above and below that for our own use.

Patch Set 1 #

Patch Set 2 : Puts an allowed range on z-index. #

Patch Set 3 : Puts an allowed range on z-index. #

Patch Set 4 : Puts an allowed range on z-index. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -10 lines) Patch
M src/com/google/caja/lang/css/CssPropBit.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/lang/css/CssPropertyPatterns.java View 1 2 3 chunks +9 lines, -2 lines 0 comments Download
M src/com/google/caja/lang/css/css21-defs.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/parser/css/CssPropertySignature.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/com/google/caja/plugin/CssValidator.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/plugin/sanitizecss.js View 1 2 3 chunks +13 lines, -4 lines 0 comments Download
M tests/com/google/caja/plugin/CssRewriterTest.java View 1 2 2 chunks +30 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/cssparser_test.js View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-dom-guest.html View 1 2 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4
metaweta
14 years, 3 months ago (2012-03-09 19:24:38 UTC) #1
felix8a
looks ok, but how about add a test for the client-side css sanitizer in tests/src/com/google/caja/plugin/sanitizecss_test.js
14 years, 3 months ago (2012-03-09 23:27:58 UTC) #2
metaweta
14 years, 3 months ago (2012-03-20 23:27:17 UTC) #3
felix8a
14 years, 3 months ago (2012-03-21 00:15:35 UTC) #4
(verbal review).  other than removing es5mode restriction in the test, LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b