Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2367)

Issue 577410045: Clean up embedded scheme parsing/evaluation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by hanwenn
Modified:
3 days, 7 hours ago
Reviewers:
dak, carl.d.sorensen, dan, benko.pal, Dan Eble, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Clean up embedded scheme parsing/evaluation. Renames and reorders functions to clarify the mechanism. Separates input and output parameters. No consequential functional changes.

Patch Set 1 #

Total comments: 3

Patch Set 2 : comments #

Total comments: 2

Patch Set 3 : trailing space #

Patch Set 4 : remove pointer #

Total comments: 2

Patch Set 5 : drop 'hi' local var. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -102 lines) Patch
M lily/include/parse-scm.hh View 1 1 chunk +2 lines, -18 lines 0 comments Download
M lily/lexer.ll View 1 4 chunks +17 lines, -12 lines 0 comments Download
M lily/parse-scm.cc View 1 2 3 4 3 chunks +90 lines, -72 lines 0 comments Download
M lily/undead.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 32
hanwenn
this is preparation for https://github.com/hanwen/lilypond/commit/599878a08c18323810aaa1dee3bf4d9b208e223c
2 weeks, 6 days ago (2020-01-27 08:48:53 UTC) #1
Dan Eble
https://codereview.appspot.com/577410045/diff/571430047/lily/include/parse-scm.hh File lily/include/parse-scm.hh (right): https://codereview.appspot.com/577410045/diff/571430047/lily/include/parse-scm.hh#newcode30 lily/include/parse-scm.hh:30: SCM parse_embedded_scheme (Input *i, bool safe, Lily_parser *parser); Changing ...
2 weeks, 6 days ago (2020-01-27 13:39:31 UTC) #2
hanwenn
https://codereview.appspot.com/577410045/diff/571430047/lily/include/parse-scm.hh File lily/include/parse-scm.hh (right): https://codereview.appspot.com/577410045/diff/571430047/lily/include/parse-scm.hh#newcode30 lily/include/parse-scm.hh:30: SCM parse_embedded_scheme (Input *i, bool safe, Lily_parser *parser); On ...
2 weeks, 4 days ago (2020-01-28 22:06:33 UTC) #3
dak
https://codereview.appspot.com/577410045/diff/571430047/lily/include/parse-scm.hh File lily/include/parse-scm.hh (right): https://codereview.appspot.com/577410045/diff/571430047/lily/include/parse-scm.hh#newcode30 lily/include/parse-scm.hh:30: SCM parse_embedded_scheme (Input *i, bool safe, Lily_parser *parser); On ...
2 weeks, 4 days ago (2020-01-28 22:37:19 UTC) #4
Dan Eble
On 2020/01/28 22:06:33, hanwenn wrote: > > In general, pointers are preferred in function signatures, ...
2 weeks, 4 days ago (2020-01-28 23:38:24 UTC) #5
hanwenn
comments
2 weeks, 4 days ago (2020-01-29 06:28:13 UTC) #6
hanwenn
On 2020/01/28 23:38:24, Dan Eble wrote: > On 2020/01/28 22:06:33, hanwenn wrote: > > > ...
2 weeks, 4 days ago (2020-01-29 06:36:07 UTC) #7
dak
On 2020/01/29 06:36:07, hanwenn wrote: > > BTW - I don't want to tell a ...
2 weeks, 4 days ago (2020-01-29 11:44:57 UTC) #8
dak
https://codereview.appspot.com/577410045/diff/551410043/lily/parse-scm.cc File lily/parse-scm.cc (right): https://codereview.appspot.com/577410045/diff/551410043/lily/parse-scm.cc#newcode59 lily/parse-scm.cc:59: Pouring oil on the fire... Rietveld highlighting indicates non-empty ...
2 weeks, 4 days ago (2020-01-29 14:42:22 UTC) #9
hanwenn
On 2020/01/29 11:44:57, dak wrote: > > BTW - I don't want to tell a ...
2 weeks, 3 days ago (2020-01-30 09:54:48 UTC) #10
hanwenn
trailing space
2 weeks, 3 days ago (2020-01-30 09:55:07 UTC) #11
hanwenn
https://codereview.appspot.com/577410045/diff/551410043/lily/parse-scm.cc File lily/parse-scm.cc (right): https://codereview.appspot.com/577410045/diff/551410043/lily/parse-scm.cc#newcode59 lily/parse-scm.cc:59: On 2020/01/29 14:42:22, dak wrote: > Pouring oil on ...
2 weeks, 3 days ago (2020-01-30 09:58:13 UTC) #12
dak
On 2020/01/30 09:54:48, hanwenn wrote: > On 2020/01/29 11:44:57, dak wrote: > > > BTW ...
2 weeks, 3 days ago (2020-01-30 13:58:30 UTC) #13
dan_faithful.be
On Jan 30, 2020, at 04:54, hanwenn@gmail.com wrote: > > This may predate you, but ...
2 weeks, 3 days ago (2020-01-30 14:31:07 UTC) #14
hanwenn
remove pointer
2 weeks, 2 days ago (2020-01-30 22:50:38 UTC) #15
hanwenn
On 2020/01/30 14:31:07, dan_faithful.be wrote: > On Jan 30, 2020, at 04:54, mailto:hanwenn@gmail.com wrote: > ...
2 weeks, 2 days ago (2020-01-30 23:22:46 UTC) #16
Dan Eble
On 2020/01/30 23:22:46, hanwenn wrote: > I feel this whole discussion has gone out of ...
2 weeks, 2 days ago (2020-01-31 00:31:34 UTC) #17
hanwenn
On Fri, Jan 31, 2020 at 1:31 AM <nine.fierce.ballads@gmail.com> wrote: > > On 2020/01/30 23:22:46, ...
2 weeks, 2 days ago (2020-01-31 07:30:23 UTC) #18
hanwenn
On Fri, Jan 31, 2020 at 8:30 AM Han-Wen Nienhuys <hanwenn@gmail.com> wrote: > Locally, I ...
2 weeks, 2 days ago (2020-01-31 07:36:57 UTC) #19
hanwenn
Adapted description. On Fri, Jan 31, 2020 at 8:36 AM Han-Wen Nienhuys <hanwenn@gmail.com> wrote: > ...
2 weeks, 2 days ago (2020-01-31 07:39:28 UTC) #20
benko.pal
https://codereview.appspot.com/577410045/diff/581560047/lily/parse-scm.cc File lily/parse-scm.cc (right): https://codereview.appspot.com/577410045/diff/581560047/lily/parse-scm.cc#newcode77 lily/parse-scm.cc:77: const Input *hi = &ps->start_; I understand (and like) ...
2 weeks, 2 days ago (2020-01-31 10:49:13 UTC) #21
hanwenn
https://codereview.appspot.com/577410045/diff/581560047/lily/parse-scm.cc File lily/parse-scm.cc (right): https://codereview.appspot.com/577410045/diff/581560047/lily/parse-scm.cc#newcode77 lily/parse-scm.cc:77: const Input *hi = &ps->start_; On 2020/01/31 10:49:13, benko.pal ...
2 weeks, 2 days ago (2020-01-31 10:55:46 UTC) #22
benko.pal
<hanwenn@gmail.com> ezt írta (időpont: 2020. jan. 31., P, 11:55): > > > https://codereview.appspot.com/577410045/diff/581560047/lily/parse-scm.cc > File ...
2 weeks, 2 days ago (2020-01-31 11:04:12 UTC) #23
Dan Eble
On 2020/01/30 23:22:46, hanwenn wrote: > In the lily/ directory > > git grep 'vector<[^>]\+> ...
2 weeks, 2 days ago (2020-01-31 17:38:55 UTC) #24
hanwenn
On 2020/01/31 17:38:55, Dan Eble wrote: > On 2020/01/30 23:22:46, hanwenn wrote: > > In ...
2 weeks, 2 days ago (2020-01-31 17:52:45 UTC) #25
Dan Eble
On 2020/01/31 17:52:45, hanwenn wrote: > you can do a local alias > > vector<> ...
2 weeks, 2 days ago (2020-01-31 18:22:47 UTC) #26
hanwenn
drop 'hi' local var.
2 weeks, 2 days ago (2020-01-31 18:32:51 UTC) #27
hanwenn
On 2020/01/31 18:22:47, Dan Eble wrote: > On 2020/01/31 17:52:45, hanwenn wrote: > > you ...
2 weeks, 2 days ago (2020-01-31 18:33:09 UTC) #28
dan_faithful.be
On Jan 31, 2020, at 13:33, hanwenn@gmail.com wrote: > > On 2020/01/31 18:22:47, Dan Eble ...
2 weeks, 2 days ago (2020-01-31 18:43:34 UTC) #29
Carl
On 2020/01/31 18:33:09, hanwenn wrote: > On 2020/01/31 18:22:47, Dan Eble wrote: > > On ...
2 weeks, 1 day ago (2020-01-31 19:07:05 UTC) #30
hanwenn
https://sourceforge.net/p/testlilyissues/issues/5737/
1 week, 4 days ago (2020-02-05 08:19:20 UTC) #31
hanwenn
3 days, 7 hours ago (2020-02-13 11:42:18 UTC) #32
commit 5a4039b700f3a7447401780c720070d14e2891bd
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Fri Jan 31 08:24:44 2020 +0100

    Clean up embedded scheme parsing/evaluation.
    
    Renames and reorders functions to clarify the mechanism. No
    consequential functional changes.
    
    Separates input and output parameters.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b