Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(59)

Issue 577390043: Only print out open type font substitution if there was a change (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by hanwenn
Modified:
1 month, 3 weeks ago
Reviewers:
Dan Eble, lemzwerg, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Only print out open type font substitution if there was a change This makes debug output less unwieldy.

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : rephrase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M lily/open-type-font.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6
hanwenn
rebase
2 months, 2 weeks ago (2020-01-24 10:09:59 UTC) #1
lemzwerg
Grammar nit. https://codereview.appspot.com/577390043/diff/573430045/lily/open-type-font.cc File lily/open-type-font.cc (right): https://codereview.appspot.com/577390043/diff/573430045/lily/open-type-font.cc#newcode238 lily/open-type-font.cc:238: debug_output (_f ("Replace font name from %s ...
2 months, 2 weeks ago (2020-01-24 17:37:42 UTC) #2
Dan Eble
On 2020/01/24 17:37:42, lemzwerg wrote: > Replace font name '%s' with '%s'. Yes, or, Change ...
2 months, 2 weeks ago (2020-01-24 17:46:33 UTC) #3
Carl
On 2020/01/24 17:46:33, Dan Eble wrote: > On 2020/01/24 17:37:42, lemzwerg wrote: > > Replace ...
2 months, 2 weeks ago (2020-01-24 17:49:25 UTC) #4
hanwenn
rephrase
2 months, 1 week ago (2020-01-31 18:05:13 UTC) #5
hanwenn
1 month, 3 weeks ago (2020-02-13 11:38:56 UTC) #6
commit af11dc2109631c3bd2912cee438b60d2799f1a53
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Thu Jan 23 22:41:14 2020 +0100

    Issue 5682: only print out open type font substitution if there was a change
    
    This makes debug output less unwieldy.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b