Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(692)

Issue 577320043: Remove broken and undocumented tracing features (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by hahnjo
Modified:
2 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove broken and undocumented tracing features Individual changes: 1. Drop -dtrace-scheme-coverage As the initial commit dee82b1d0b of scm/coverage.scm notes, this module requires support for memoize-symbol. This was indeed added for Guile 1.9.0, but again removed in version 1.9.13. That means there never was a stable version of Guile that worked with this. When building / running with current Guile 1.8.8, the executable crashes because the interpreter raise()s from within a critical section and (at least my) libc kills the process: $ guile1.8 -c "(trap-enable 'memoize-symbol)" throw from within critical section. Aborted (core dumped) (With later releases of Guile, there's at least an error message: $ guile2.0 -c "(trap-enable 'memoize-symbol)" [...] ERROR: In procedure memoize-variable-access!: ERROR: Unbound variable: trap-enable This is because the mentioned (unstable) release 1.9.13 completely removed not only memoize-symbol, but the whole trap-* interface.) 2. Drop -dtrace-memory-frequency The existing documentation is outdated: * The option is not bool, but takes an integer. Maybe the frequency, but in what unit? * The mentioned patch has been part of Guile since version 1.8.2. However I can't find the added variable since release 1.9.3, not unlikely that the module would not work with later versions. Additionally there is no guide on how to use the produced files (.stacks and .graph). If somebody has more information and wants this feature back, please revert this commit and add appropriate documentation. 3. Delete scripts to measure coverage build-coverage.sh is meant to configure LilyPond for gathering coverage information, then runs a full 'make test' and finally calls coverage.py to postprocess the data. Apart from using the broken -dtrace-scheme-coverage, build-coverage.sh only works when called from the repository's root directory (as opposed to just creating a new build directory). Furthermore it randomly touches midi2ly and its manpage midi2ly.1 which leads to errors at first. Finally the called covarage.py doesn't seem to handle coverage data emitted by the latest GCC, which makes it useless going forward. 4. Delete script build-profile.sh It's not described in the documentation and seems to expect files in input/mutopia which was removed back in 2009. 5. Update documentation about tracing options

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -773 lines) Patch
M Documentation/ca/usage/running.itely View 1 chunk +0 lines, -10 lines 0 comments Download
M Documentation/contributor/regressions.itexi View 2 chunks +0 lines, -29 lines 0 comments Download
M Documentation/de/usage/running.itely View 1 chunk +0 lines, -9 lines 0 comments Download
M Documentation/es/usage/running.itely View 1 chunk +0 lines, -10 lines 0 comments Download
M Documentation/fr/usage/running.itely View 1 chunk +0 lines, -10 lines 0 comments Download
M Documentation/it/usage/running.itely View 1 chunk +0 lines, -9 lines 0 comments Download
M Documentation/ja/usage/running.itely View 1 chunk +0 lines, -9 lines 0 comments Download
M Documentation/usage/running.itely View 1 chunk +0 lines, -11 lines 0 comments Download
D scm/coverage.scm View 1 chunk +0 lines, -94 lines 0 comments Download
M scm/lily.scm View 5 chunks +1 line, -25 lines 0 comments Download
D scm/memory-trace.scm View 1 chunk +0 lines, -155 lines 0 comments Download
D scripts/auxiliar/build-coverage.sh View 1 chunk +0 lines, -67 lines 0 comments Download
D scripts/auxiliar/build-profile.sh View 1 chunk +0 lines, -87 lines 0 comments Download
D scripts/auxiliar/coverage.py View 1 chunk +0 lines, -248 lines 0 comments Download

Messages

Total messages: 1
lemzwerg
2 months, 2 weeks ago (2020-01-19 06:33:32 UTC) #1
LGTM, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b