Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 577280043: Cleanup unneeded parts of Stepmake (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by hahnjo
Modified:
2 months, 2 weeks ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Cleanup unneeded parts of Stepmake Individual changes: 1. Remove line break from STEPMAKE_TEMPLATES It's easier to analyze when all values are in a single line. 2. Drop unused stepmake templates A list of needed one can be obtained by the following: $ git grep "STEPMAKE_TEMPLATES.*=" | sed "s/.*=\W*\(.*\)/\1/" | \ tr ' ' '\n' | sort -u | grep -v "\\\$" However we cannot simply delete all others because some are referenced elsewhere, so it's a manual process of checking the candidates. 3. Drop support for compiling C files All source code is C++ by now, move the used rules to c++-*.make. 4. Simplify python/GNUmakefile OUT_SO_MODULES and OUT_PYC_MODULES don't exist anymore. 5. Delete flower/VERSION This is very old and I don't think this file is used. Also get rid of FLOWER_VERSION and FULL_FLOWER_VERSION which aren't used either. 6. Delete no-builtin-rules.make The implicit rules are only used if no other rule can be found. We define all needed rules ourselves, so they should not harm.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -474 lines) Patch
M Documentation/contributor/build-notes.itexi View 3 chunks +2 lines, -25 lines 0 comments Download
M configure.ac View 1 chunk +0 lines, -2 lines 0 comments Download
D flower/VERSION View 1 chunk +0 lines, -9 lines 0 comments Download
M lily/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M make/stepmake.make View 1 chunk +0 lines, -10 lines 0 comments Download
M mf/GNUmakefile View 1 chunk +1 line, -3 lines 0 comments Download
M python/GNUmakefile View 1 chunk +2 lines, -7 lines 0 comments Download
D stepmake/stepmake/automatically-configured.sub.make View 1 chunk +0 lines, -1 line 0 comments Download
D stepmake/stepmake/automatically-generated.sub.make View 1 chunk +0 lines, -10 lines 0 comments Download
M stepmake/stepmake/c++-rules.make View 1 chunk +1 line, -1 line 0 comments Download
M stepmake/stepmake/c++-vars.make View 1 chunk +14 lines, -1 line 0 comments Download
D stepmake/stepmake/c-rules.make View 1 chunk +0 lines, -31 lines 0 comments Download
D stepmake/stepmake/c-targets.make View 1 chunk +0 lines, -1 line 0 comments Download
D stepmake/stepmake/c-vars.make View 1 chunk +0 lines, -18 lines 0 comments Download
D stepmake/stepmake/compile-vars.make View 1 chunk +0 lines, -19 lines 0 comments Download
D stepmake/stepmake/install-library-rules.make View 1 chunk +0 lines, -1 line 0 comments Download
D stepmake/stepmake/install-library-targets.make View 1 chunk +0 lines, -22 lines 0 comments Download
D stepmake/stepmake/install-library-vars.make View 1 chunk +0 lines, -1 line 0 comments Download
D stepmake/stepmake/install.sub.make View 1 chunk +0 lines, -4 lines 0 comments Download
D stepmake/stepmake/makedir-rules.make View 1 chunk +0 lines, -1 line 0 comments Download
D stepmake/stepmake/makedir-targets.make View 1 chunk +0 lines, -4 lines 0 comments Download
D stepmake/stepmake/makedir-vars.make View 1 chunk +0 lines, -14 lines 0 comments Download
D stepmake/stepmake/no-builtin-rules.make View 1 chunk +0 lines, -242 lines 0 comments Download
D stepmake/stepmake/shared-library-rules.make View 1 chunk +0 lines, -6 lines 0 comments Download
D stepmake/stepmake/shared-library-targets.make View 1 chunk +0 lines, -4 lines 0 comments Download
D stepmake/stepmake/shared-library-vars.make View 1 chunk +0 lines, -33 lines 0 comments Download
M stepmake/stepmake/toplevel-targets.make View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 1
lemzwerg
3 months ago (2020-01-08 16:53:36 UTC) #1
LGTM, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b