Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4813)

Issue 577130043: add suggestAccidentals = #'cautionary option

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 2 days ago by Malte Meyn
Modified:
2 weeks ago
Reviewers:
Dan Eble, lemzwerg, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

add suggestAccidentals = #'cautionary option Setting suggestAccidentals to 'cautionary now prints only cautionary accidentals (input by ?) as AccidentalSuggestion.

Patch Set 1 #

Patch Set 2 : add changes entry (untested, see mail on lilypond-devel) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M Documentation/changes.tely View 1 1 chunk +17 lines, -0 lines 0 comments Download
M input/regression/accidental-suggestions.ly View 1 chunk +9 lines, -9 lines 0 comments Download
M lily/accidental-engraver.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M scm/define-context-properties.scm View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6
lemzwerg
LGTM
2 weeks, 2 days ago (2019-11-21 11:58:35 UTC) #1
Dan Eble
Idea and implementation LGTM.
2 weeks, 2 days ago (2019-11-21 12:18:12 UTC) #2
Carl
Very nice. I think there should be a changes.tely entry. Carl
2 weeks, 2 days ago (2019-11-21 14:31:42 UTC) #3
Carl
Very nice. I think there should be a changes.tely entry. Carl
2 weeks, 2 days ago (2019-11-21 14:31:42 UTC) #4
Malte Meyn
On 2019/11/21 14:31:42, Carl wrote: > Very nice. > > I think there should be ...
2 weeks, 1 day ago (2019-11-22 12:54:52 UTC) #5
Malte Meyn
2 weeks ago (2019-11-23 11:25:09 UTC) #6
add changes entry (untested, see mail on lilypond-devel)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b