Issue 57710043: uniter: restore ability to read removed units

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 57710043: uniter: restore ability to read removed units

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by fwereade

Modified:
10 years, 2 months ago

Reviewers:
mp+203505, dimitern, rog

Visibility:
Public.

Description

uniter: restore ability to read removed units disallowing this breaks the juju model (arbitrary time-shifting between units). also driveby fixed a couple of potential panics in uniter facade https://code.launchpad.net/~fwereade/juju-core/uniter-removed-unit-settings/+merge/203505 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -15 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/apiserver/uniter/uniter.go	View	2 chunks	+11 lines, -10 lines	3 comments	Download
M	state/apiserver/uniter/uniter_test.go	View	3 chunks	+18 lines, -4 lines	0 comments	Download
M	worker/uniter/context_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dimitern

LGTM https://codereview.appspot.com/57710043/diff/1/state/apiserver/uniter/uniter.go File state/apiserver/uniter/uniter.go (right): https://codereview.appspot.com/57710043/diff/1/state/apiserver/uniter/uniter.go#newcode75 state/apiserver/uniter/uniter.go:75: _, name, err := names.ParseTag(tag, names.UnitTagKind) Nice catch! ...

10 years, 3 months ago (2014-01-28 10:57:57 UTC) #2

rog

10 years, 2 months ago (2014-02-14 10:53:18 UTC) #3

LGTM with a suggestion.

https://codereview.appspot.com/57710043/diff/1/state/apiserver/uniter/uniter.go
File state/apiserver/uniter/uniter.go (right):

https://codereview.appspot.com/57710043/diff/1/state/apiserver/uniter/uniter....
state/apiserver/uniter/uniter.go:857: // Check remoteUnit is indeed related.
// Note that we don't want to get the remote unit
// here, because it might legitimately be removed
// but we still want to allow access to its settings.

?

Expand All Messages | Collapse All Messages