Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1339)

Issue 57690051: Fix sandbox mode.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by frankban
Modified:
10 years, 2 months ago
Reviewers:
mp+204754, gary.poster
Visibility:
Public.

Description

Fix sandbox mode. The proxy handler is now started only if the GUI is connected to a real environment. Tests: `make unittest`. QA: `make deploy` `juju set juju-gui sandbox=true` Wait for the unit to be started. Ensure everything works well. https://code.launchpad.net/~frankban/charms/precise/juju-gui/fix-sandbox-mode/+merge/204754 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix sandbox mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M server/guiserver/apps.py View 2 chunks +6 lines, -6 lines 0 comments Download
M server/guiserver/tests/test_apps.py View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
10 years, 2 months ago (2014-02-04 17:41:12 UTC) #1
gary.poster
LGTM and QA good. Thank you!
10 years, 2 months ago (2014-02-04 18:58:08 UTC) #2
frankban
*** Submitted: Fix sandbox mode. The proxy handler is now started only if the GUI ...
10 years, 2 months ago (2014-02-05 09:05:47 UTC) #3
frankban
10 years, 2 months ago (2014-02-05 09:19:37 UTC) #4
Thank you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b