Making sure the extra log functions are unique.

Making sure the extra log functions are unique.

Previously, if log.addLoggerFunction were called n times with
the same function then each log message would appear n times.

This would be noticed in Spark when tavern is called multiple times
as the log.addLoggerFunction is called every time.

R=tapted@chromium.org

Committed: https://github.com/tapted/bleeding_edge/commit/a6ef445

[pajamallama, 2014-01-28 04:08:32]

In theory I could set a flag to Spark to make sure the extra log function is
only ever added once, but it doesn't make sense to log to the same output
multiple times anyway.

[tapted, 2014-01-28 05:48:11]

lgtm. I guess it is common in <insert random logging framework> to have a
run_once/singleton to initialize logging, but I this works too. Although there
may be other problems stemming from cases where these init flows can execute
multiple times when opening the logging window.

https://codereview.appspot.com/57610043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/log.dart (right):

https://codereview.appspot.com/57610043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/log.dart:38: var _otherLogFunctions = new
LinkedHashSet<Function>();
nit: maybe Collection<Function>? I think it's nice to have data members with a
known type rather than `var`

[pajamallama, 2014-01-28 06:51:13]

Committed patchset #2 manually as ra6ef445 (presubmit successful).

[pajamallama, 2014-01-28 06:52:21]

https://codereview.appspot.com/57610043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/log.dart (right):

https://codereview.appspot.com/57610043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/log.dart:38: var _otherLogFunctions = new
LinkedHashSet<Function>();
On 2014/01/28 05:48:12, tapted wrote:
> nit: maybe Collection<Function>? I think it's nice to have data members with a
> known type rather than `var`

Done.