Remove all uses of markup macro from scm/*.scm

Remove all uses of markup macro from scm/*.scm

The markup macro is a major portability headache for getting
byte-compilation with Guilev2 to work.  This removes all uses of it
from within the scm code base of LilyPond while keeping it around (for
now) for use from files in LilyPond syntax.


This actually also includes the single commit from

Issue 5873: Refactor \markup \pattern

[thomasmorley651, 2020-03-30 20:32:59]

patch itself LGTM

Ofcourse there are other folders than scm/*.scm, like snippets, snippets/new,
ly-examples, Documentation...
Follow up planned?

[hanwenn, 2020-03-30 21:15:16]

thanks!

Harm, the changes only need to be done in .scm, because it's only those files
that we'd be precompiling

https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.scm
File scm/time-signature.scm (right):

https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.sc...
scm/time-signature.scm:23: (mup (if (procedure? proc)
nitpick: how about 'fraction-markup' or 'fraction' ?

https://codereview.appspot.com/575930043/diff/561620044/scm/titling.scm
File scm/titling.scm (right):

https://codereview.appspot.com/575930043/diff/561620044/scm/titling.scm#newco...
scm/titling.scm:102: (mup (ly:output-def-lookup layout what)))
title-markup ?

[hanwenn, 2020-03-30 21:15:25]

LGTM

[dak, 2020-03-30 21:27:51]

Suggested naming changes

[dak, 2020-03-30 21:30:11]

https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.scm
File scm/time-signature.scm (right):

https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.sc...
scm/time-signature.scm:23: (mup (if (procedure? proc)
On 2020/03/30 21:15:15, hanwenn wrote:
> nitpick: how about 'fraction-markup' or 'fraction' ?

Done.

Strictly speaking, the change was likely not necessary in the first place, but
I'd hate keeping (markup ... around in a file, even though it means something
entirely different here.

https://codereview.appspot.com/575930043/diff/561620044/scm/titling.scm
File scm/titling.scm (right):

https://codereview.appspot.com/575930043/diff/561620044/scm/titling.scm#newco...
scm/titling.scm:102: (mup (ly:output-def-lookup layout what)))
On 2020/03/30 21:15:15, hanwenn wrote:
> title-markup ?
> 

Done.

[hanwenn, 2020-04-03 22:22:31]

note that this still doesn't fix the next error message for compilation which is



fatal error: Not a markup command: line

which is triggered by the *definition* of the markup macro:

(defmacro*-public markup (#:rest body)
..
  (car (compile-all-markup-expressions `(#:line ,body))))

the markup compilation tries to lookup the 'line' markup dynamically, and fails.

[dak, 2020-04-03 23:27:47]

On 2020/04/03 22:22:31, hanwenn wrote:
> note that this still doesn't fix the next error message for compilation which
is
> 
> 
> 
> fatal error: Not a markup command: line
> 
> which is triggered by the *definition* of the markup macro:
> 
> (defmacro*-public markup (#:rest body)
> ..
>   (car (compile-all-markup-expressions `(#:line ,body))))
> 
> the markup compilation tries to lookup the 'line' markup dynamically, and
fails.

I propose to leave this new but related piece of crock for the next issue as it
seems a bit more involved and warrants separate analysis, testing and fixing.

[hanwenn, 2020-04-04 11:40:16]

On 2020/04/03 23:27:47, dak wrote:
> On 2020/04/03 22:22:31, hanwenn wrote:
> > note that this still doesn't fix the next error message for compilation
which
> is
> > 
> > 
> > 
> > fatal error: Not a markup command: line
> > 
> > which is triggered by the *definition* of the markup macro:
> > 
> > (defmacro*-public markup (#:rest body)
> > ..
> >   (car (compile-all-markup-expressions `(#:line ,body))))
> > 
> > the markup compilation tries to lookup the 'line' markup dynamically, and
> fails.
> 
> I propose to leave this new but related piece of crock for the next issue as
it
> seems a bit more involved and warrants separate analysis, testing and fixing.

I fully agree, I just wanted to register my insight.