Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2146)

Issue 575930043: Remove all uses of markup macro from scm/*.scm

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by dak
Modified:
4 years, 11 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove all uses of markup macro from scm/*.scm The markup macro is a major portability headache for getting byte-compilation with Guilev2 to work. This removes all uses of it from within the scm code base of LilyPond while keeping it around (for now) for use from files in LilyPond syntax. This actually also includes the single commit from Issue 5873: Refactor \markup \pattern

Patch Set 1 #

Total comments: 4

Patch Set 2 : Suggested naming changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -153 lines) Patch
M scm/accreg.scm View 1 chunk +5 lines, -5 lines 0 comments Download
M scm/define-markup-commands.scm View 22 chunks +70 lines, -54 lines 0 comments Download
M scm/define-woodwind-diagrams.scm View 1 chunk +22 lines, -31 lines 0 comments Download
M scm/stencil.scm View 1 chunk +10 lines, -10 lines 0 comments Download
M scm/tablature.scm View 1 chunk +11 lines, -5 lines 0 comments Download
M scm/time-signature.scm View 1 1 chunk +4 lines, -4 lines 0 comments Download
M scm/titling.scm View 1 1 chunk +3 lines, -3 lines 0 comments Download
M scm/translation-functions.scm View 5 chunks +51 lines, -41 lines 0 comments Download

Messages

Total messages: 8
thomasmorley651
patch itself LGTM Ofcourse there are other folders than scm/*.scm, like snippets, snippets/new, ly-examples, Documentation... ...
4 years, 11 months ago (2020-03-30 20:32:59 UTC) #1
hanwenn
thanks! Harm, the changes only need to be done in .scm, because it's only those ...
4 years, 11 months ago (2020-03-30 21:15:16 UTC) #2
hanwenn
LGTM
4 years, 11 months ago (2020-03-30 21:15:25 UTC) #3
dak
Suggested naming changes
4 years, 11 months ago (2020-03-30 21:27:51 UTC) #4
dak
https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.scm File scm/time-signature.scm (right): https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.scm#newcode23 scm/time-signature.scm:23: (mup (if (procedure? proc) On 2020/03/30 21:15:15, hanwenn wrote: ...
4 years, 11 months ago (2020-03-30 21:30:11 UTC) #5
hanwenn
note that this still doesn't fix the next error message for compilation which is fatal ...
4 years, 11 months ago (2020-04-03 22:22:31 UTC) #6
dak
On 2020/04/03 22:22:31, hanwenn wrote: > note that this still doesn't fix the next error ...
4 years, 11 months ago (2020-04-03 23:27:47 UTC) #7
hanwenn
4 years, 11 months ago (2020-04-04 11:40:16 UTC) #8
On 2020/04/03 23:27:47, dak wrote:
> On 2020/04/03 22:22:31, hanwenn wrote:
> > note that this still doesn't fix the next error message for compilation
which
> is
> > 
> > 
> > 
> > fatal error: Not a markup command: line
> > 
> > which is triggered by the *definition* of the markup macro:
> > 
> > (defmacro*-public markup (#:rest body)
> > ..
> >   (car (compile-all-markup-expressions `(#:line ,body))))
> > 
> > the markup compilation tries to lookup the 'line' markup dynamically, and
> fails.
> 
> I propose to leave this new but related piece of crock for the next issue as
it
> seems a bit more involved and warrants separate analysis, testing and fixing.

I fully agree, I just wanted to register my insight.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b