Issue 57590043: Fix the proxy env vars in the uniter.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 57590043: Fix the proxy env vars in the uniter.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by thumper

Modified:
10 years, 3 months ago

Reviewers:
wallyworld, mp+203459

Visibility:
Public.

Description

Fix the proxy env vars in the uniter. The shell variables exported in the uniter are incorrect. They should have underscores not dashes. In an attempt to reduce the likelihood of this happening again, moved the proxy code to use string constants. https://code.launchpad.net/~thumper/juju-core/fix-uniter-proxy-env-vars/+merge/203459 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -36 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/config/config.go	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	environs/config/config_test.go	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	juju/osenv/proxy.go	View	5 chunks	+26 lines, -18 lines	0 comments	Download
M	juju/osenv/proxy_test.go	View	1 chunk	+10 lines, -6 lines	0 comments	Download
M	provider/local/environprovider_test.go	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	worker/uniter/uniter_test.go	View	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages