store: bootstrap juju HTTP API server

Serves properly /charm-info as required by the client.

https://code.launchpad.net/~niemeyer/juju/go-store-server/+merge/96055

(do not edit description out of merge proposal)

[niemeyer, 2012-03-06 04:16:25]

Please take a look.

[fwereade, 2012-03-06 08:16:11]

LGTM

[rog, 2012-03-06 16:12:10]

https://codereview.appspot.com/5755047/diff/1/store/server.go
File store/server.go (right):

https://codereview.appspot.com/5755047/diff/1/store/server.go#newcode10
store/server.go:10: // Server is an http.Handler that serves the HTTP API of
juju
is the HTTP API specified or documented anywhere?

https://codereview.appspot.com/5755047/diff/1/store/server.go#newcode11
store/server.go:11: // so that juju clients can consume published charms.
s/consume/retrieve/ ?

https://codereview.appspot.com/5755047/diff/1/store/server.go#newcode23
store/server.go:23: s.mux.HandleFunc("/charm-info", func(w http.ResponseWriter,
r *http.Request) {
rather than using ServeMux here, wouldn't it be better to check the URL inside
serveInfo.
http://charmserver.com/charm-info/fooey should return a 404 error IMHO.

[niemeyer, 2012-03-06 17:29:19]

https://codereview.appspot.com/5755047/diff/1/store/server.go
File store/server.go (right):

https://codereview.appspot.com/5755047/diff/1/store/server.go#newcode10
store/server.go:10: // Server is an http.Handler that serves the HTTP API of
juju
On 2012/03/06 16:12:10, rog wrote:
> is the HTTP API specified or documented anywhere?

Yes, in the charm store spec too.

https://codereview.appspot.com/5755047/diff/1/store/server.go#newcode11
store/server.go:11: // so that juju clients can consume published charms.
Sounds good.

https://codereview.appspot.com/5755047/diff/1/store/server.go#newcode23
store/server.go:23: s.mux.HandleFunc("/charm-info", func(w http.ResponseWriter,
r *http.Request) {
On 2012/03/06 16:12:10, rog wrote:
> rather than using ServeMux here, wouldn't it be better to check the URL inside
serveInfo.

We'd have to reimplement the mux ourselves if we don't have this. It may sounds
silly now, but it'll make more sense once we have more URLs (e.g. /charm is
coming).

> http://charmserver.com/charm-info/fooey should return a 404 error IMHO.

[rog, 2012-03-06 17:32:23]

https://codereview.appspot.com/5755047/diff/1/store/server.go
File store/server.go (right):

https://codereview.appspot.com/5755047/diff/1/store/server.go#newcode23
store/server.go:23: s.mux.HandleFunc("/charm-info", func(w http.ResponseWriter,
r *http.Request) {
On 2012/03/06 17:29:19, niemeyer wrote:
> On 2012/03/06 16:12:10, rog wrote:
> > rather than using ServeMux here, wouldn't it be better to check the URL
inside
> serveInfo.
> 
> We'd have to reimplement the mux ourselves if we don't have this. It may
sounds
> silly now, but it'll make more sense once we have more URLs (e.g. /charm is
> coming).
> 
> > http://charmserver.com/charm-info/fooey should return a 404 error IMHO.
> 

fair enough. but you'll still need to check the URL inside serveInfo.

[niemeyer, 2012-03-06 19:05:35]

https://codereview.appspot.com/5755047/diff/1/store/server.go
File store/server.go (right):

https://codereview.appspot.com/5755047/diff/1/store/server.go#newcode23
store/server.go:23: s.mux.HandleFunc("/charm-info", func(w http.ResponseWriter,
r *http.Request) {
On 2012/03/06 17:32:24, rog wrote:
> On 2012/03/06 17:29:19, niemeyer wrote:
> > On 2012/03/06 16:12:10, rog wrote:
> > > rather than using ServeMux here, wouldn't it be better to check the URL
> inside
> > serveInfo.
> > 
> > We'd have to reimplement the mux ourselves if we don't have this. It may
> sounds
> > silly now, but it'll make more sense once we have more URLs (e.g. /charm is
> > coming).
> > 
> > > http://charmserver.com/charm-info/fooey should return a 404 error IMHO.
> > 
> 
> fair enough. but you'll still need to check the URL inside serveInfo.

Done.

[niemeyer, 2012-03-06 19:07:55]

*** Submitted:

store: bootstrap juju HTTP API server

Serves properly /charm-info as required by the client.

R=fwereade, rog
CC=
https://codereview.appspot.com/5755047