Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1210)

Issue 575330043: add property label-alignments to OttavaBracket

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 3 weeks ago by Malte Meyn
Modified:
3 months, 1 week ago
Reviewers:
thomasmorley651, lemzwerg, carl.d.sorensen, c_sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

add property label-alignments to OttavaBracket

Patch Set 1 #

Total comments: 1

Patch Set 2 : label-alignments for VoltaBrackets and line spanners, changes entry #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -17 lines) Patch
M Documentation/changes.tely View 1 1 chunk +42 lines, -0 lines 2 comments Download
M input/regression/event-listener-output.ly View 1 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/line-arrows.ly View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lily/include/stencil.hh View 1 2 chunks +2 lines, -0 lines 0 comments Download
M lily/line-spanner.cc View 1 2 chunks +8 lines, -9 lines 0 comments Download
M lily/ottava-bracket.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M lily/stencil.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download
M lily/volta-bracket.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scm/define-grob-properties.scm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12
lemzwerg
Very nice, LGTM!
7 months, 3 weeks ago (2019-11-21 13:48:37 UTC) #1
Carl
I've added a comment about the docstring -- it's a request for consideration, not a ...
7 months, 3 weeks ago (2019-11-21 14:29:35 UTC) #2
Malte Meyn
Hm, I think you’re right. I’m not sure how interface work but maybe this is ...
7 months, 3 weeks ago (2019-11-22 12:56:00 UTC) #3
thomasmorley651
What about a regtest?
7 months, 3 weeks ago (2019-11-22 20:34:32 UTC) #4
Malte Meyn
On 2019/11/22 12:56:00, Malte Meyn wrote: > I just managed to do the same thing ...
7 months, 3 weeks ago (2019-11-23 11:18:10 UTC) #5
Malte Meyn
On 2019/11/23 11:18:10, Malte Meyn wrote: > I would suggest to: > • add the ...
7 months, 2 weeks ago (2019-11-27 05:40:16 UTC) #6
c_sorensen
On 11/26/19, 10:40 PM, "lilypond@maltemeyn.de" <lilypond@maltemeyn.de> wrote: On 2019/11/23 11:18:10, Malte Meyn wrote: > I ...
7 months, 2 weeks ago (2019-11-27 05:52:27 UTC) #7
Malte Meyn
label-alignments for VoltaBrackets and line spanners, changes entry
3 months, 2 weeks ago (2020-03-29 14:01:31 UTC) #8
Malte Meyn
On 2020/03/29 14:01:31, Malte Meyn wrote: > label-alignments for VoltaBrackets and line spanners, changes entry ...
3 months, 2 weeks ago (2020-03-29 14:04:09 UTC) #9
lemzwerg
Minor doc nits. https://codereview.appspot.com/575330043/diff/549780043/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/575330043/diff/549780043/Documentation/changes.tely#newcode67 Documentation/changes.tely:67: @item The labels can be changed ...
3 months, 2 weeks ago (2020-03-29 14:23:29 UTC) #10
Malte Meyn
On 2020/03/29 14:23:29, lemzwerg wrote: > Minor doc nits. I’ll include those fixes in the ...
3 months, 1 week ago (2020-03-29 16:35:54 UTC) #11
Malte Meyn
3 months, 1 week ago (2020-04-01 08:20:24 UTC) #12
On 2020/03/29 16:35:54, Malte Meyn wrote:
> On 2020/03/29 14:23:29, lemzwerg wrote:
> > Minor doc nits.
> 
> I’ll include those fixes in the next patch set.

I killed my laptop using a glass of water and cannot contribute until it’s live
again. Below you can see a proposal for a regtest. I still will need help with
the convert-ly rule.

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
\version "2.21.0"

\header {
  idontknowhowtonamethisdocstring =
  "Labels of line spanners, OttavaBrackets and VoltaBrackets
can be differently aligned for spanners below and above the
staff by overriding the property label-alignments."
}

\relative {
  \override Score.VoltaBracket.direction = #DOWN
  \override Score.VoltaBracketSpanner.direction = #DOWN
  \override TextSpanner.bound-details.left.text = "FOO"
  \override TextSpanner.bound-details.left.label-alignments = #(cons DOWN UP)
  \repeat volta 2 {
    \ottava 1
    c'''_\startTextSpan a f d\stopTextSpan
    \ottava -1
    c,^\startTextSpan a f d\stopTextSpan
    \ottava 0
  }
  \alternative {
    g'1
    g
  }
}
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b