Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1748)

Issue 5752045: Add SkAlphaToScale() and SkAlphaToInvScale...()

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by danakj
Modified:
8 years, 9 months ago
Reviewers:
reed1, Stephen White, ojan
CC:
backer_chromium.org, senorblanco, piman, nduca, enne
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add SkAlphaToScale() and SkAlphaToInvScale{4,8}() for various alpha bit sizes, and unit tests to verify they hold up our desired invariants when blending with pre-multiplied alpha. BUG=420 (crbug.com/113309) TEST=AlphaScaleTest

Patch Set 1 #

Patch Set 2 : consistent naming for SkAlphaToInvScale #

Patch Set 3 : allow for 16bit 565, name by number of alpha bits #

Patch Set 4 : don't pre-multiply dst #

Total comments: 1

Patch Set 5 : skalphatoscale: rebase #

Patch Set 6 : skalphatoscale: 2013 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -0 lines) Patch
M gyp/tests.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkColorPriv.h View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
A tests/AlphaScaleTest.cpp View 1 2 3 4 5 1 chunk +105 lines, -0 lines 0 comments Download

Messages

Total messages: 6
danakj
Here's the funtions and a unit test for them.
10 years, 2 months ago (2012-03-05 21:54:31 UTC) #1
danakj
On 2012/03/05 21:54:31, danakj wrote: > Here's the funtions and a unit test for them. ...
10 years, 2 months ago (2012-03-05 22:39:04 UTC) #2
ojan
Poke reviewers. This (hopefully) addresses a huge source of layout test failures on Mac.
10 years, 1 month ago (2012-04-13 22:41:50 UTC) #3
Stephen White
Some vacation-delayed comments and ping for Mike. Mike: ping! :) https://codereview.appspot.com/5752045/diff/3002/include/core/SkColorPriv.h File include/core/SkColorPriv.h (right): https://codereview.appspot.com/5752045/diff/3002/include/core/SkColorPriv.h#newcode21 ...
10 years ago (2012-05-08 14:53:45 UTC) #4
danakj
reed: ping
8 years, 9 months ago (2013-08-06 20:53:50 UTC) #5
danakj
8 years, 9 months ago (2013-08-06 20:59:51 UTC) #6
I've rebased this to TOT
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b