Issue 5752045: Add SkAlphaToScale() and SkAlphaToInvScale...()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5752045: Add SkAlphaToScale() and SkAlphaToInvScale...()

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by danakj

Modified:
10 years, 8 months ago

Reviewers:
reed1, Stephen White, ojan

CC:
backer_chromium.org, senorblanco, piman, nduca, enne

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add SkAlphaToScale() and SkAlphaToInvScale{4,8}() for various alpha bit sizes, and unit tests to verify they hold up our desired invariants when blending with pre-multiplied alpha. BUG=420 (crbug.com/113309) TEST=AlphaScaleTest

Patch Set 1 #

Patch Set 2 : consistent naming for SkAlphaToInvScale #

Patch Set 3 : allow for 16bit 565, name by number of alpha bits #

Patch Set 4 : don't pre-multiply dst #

Total comments: 1

Patch Set 5 : skalphatoscale: rebase #

Patch Set 6 : skalphatoscale: 2013 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -0 lines)			Patch
M	gyp/tests.gyp	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkColorPriv.h	View	1 2 3 4	1 chunk	+16 lines, -0 lines	0 comments	Download
A	tests/AlphaScaleTest.cpp	View	1 2 3 4 5	1 chunk	+105 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

danakj

On 2012/03/05 21:54:31, danakj wrote: > Here's the funtions and a unit test for them. ...

12 years, 1 month ago (2012-03-05 22:39:04 UTC) #2

ojan

Poke reviewers. This (hopefully) addresses a huge source of layout test failures on Mac.

12 years ago (2012-04-13 22:41:50 UTC) #3

Stephen White

Some vacation-delayed comments and ping for Mike. Mike: ping! :) https://codereview.appspot.com/5752045/diff/3002/include/core/SkColorPriv.h File include/core/SkColorPriv.h (right): https://codereview.appspot.com/5752045/diff/3002/include/core/SkColorPriv.h#newcode21 ...

11 years, 11 months ago (2012-05-08 14:53:45 UTC) #4

I've rebased this to TOT

Expand All Messages | Collapse All Messages