Issue 57520043: code review 57520043: net: fix incoming connection's network name handling on unix networks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 57520043: code review 57520043: net: fix incoming connection's network name handling on unix networks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by mikio

Modified:
11 years, 4 months ago

Reviewers:
iant

CC:
golang-codereviews, gobot, iant

Visibility:
Public.

Description

net: fix incoming connection's network name handling on unix networks Fixes issue 7183.

Patch Set 1 : diff -r bd927e180094 https://code.google.com/p/go #

Patch Set 2 : diff -r d5cd25037750 https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	src/pkg/net/conn_test.go	View		3 chunks	+11 lines, -5 lines	0 comments	Download
	M	src/pkg/net/unixsock_posix.go	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2014-01-28 03:04:49 UTC) #1

mikio

11 years, 4 months ago (2014-01-29 00:51:37 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=9c65fe4ce5a2 ***

net: fix incoming connection's network name handling on unix networks

Fixes issue 7183.

LGTM=iant
R=golang-codereviews, gobot, iant
CC=golang-codereviews
https://codereview.appspot.com/57520043

Expand All Messages | Collapse All Messages