Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 573730043: Use binary search in Axis_group_interface::combine_pure_heights. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 2 weeks ago by hanwenn
Modified:
4 weeks ago
Reviewers:
lemzwerg, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Use binary search in Axis_group_interface::combine_pure_heights. This used linear search, probably making the cost quadratic in the score size In the Carver MSDM score, this function accounts for ~1% of processing time.

Patch Set 1 #

Total comments: 1

Patch Set 2 : jonas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M lily/axis-group-interface.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M lily/include/paper-score.hh View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7
lemzwerg
LGTM
1 month, 2 weeks ago (2020-04-21 08:51:19 UTC) #1
hahnjo
LGTM otherwise https://codereview.appspot.com/573730043/diff/567470043/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): https://codereview.appspot.com/573730043/diff/567470043/lily/axis-group-interface.cc#newcode206 lily/axis-group-interface.cc:206: auto it = lower_bound (break_ranks.begin (), break_ranks.end ...
1 month, 2 weeks ago (2020-04-21 09:15:28 UTC) #2
hanwenn
jonas
1 month, 2 weeks ago (2020-04-22 07:50:15 UTC) #3
hanwenn
1 month, 2 weeks ago (2020-04-22 07:51:07 UTC) #4
hanwenn
On 2020/04/21 09:15:28, hahnjo wrote: > LGTM otherwise > > https://codereview.appspot.com/573730043/diff/567470043/lily/axis-group-interface.cc > File lily/axis-group-interface.cc (right): ...
1 month, 2 weeks ago (2020-04-22 07:51:22 UTC) #5
hanwenn
1 month, 2 weeks ago (2020-04-22 07:51:26 UTC) #6
hanwenn
4 weeks ago (2020-05-09 10:41:18 UTC) #7
commit 7d4ddb25cec526d9785aa041bdb1d499d3209333
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Mon Apr 20 10:31:30 2020 +0200

    Use binary search in Axis_group_interface::combine_pure_heights.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b