Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(833)

Issue 573400043: Clean up and document include file searching (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by hanwenn
Modified:
2 months, 1 week ago
Reviewers:
Dan Eble, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Clean up and document include file searching

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase; const #

Patch Set 3 : compiling #

Patch Set 4 : fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -30 lines) Patch
M flower/include/file-path.hh View 1 1 chunk +1 line, -7 lines 0 comments Download
M lily/includable-lexer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/include/includable-lexer.hh View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lily/include/sources.hh View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M lily/sources.cc View 1 3 chunks +30 lines, -19 lines 0 comments Download

Messages

Total messages: 7
lemzwerg
From inspection only: LGTM, thanks! https://codereview.appspot.com/573400043/diff/549420043/lily/includable-lexer.cc File lily/includable-lexer.cc (right): https://codereview.appspot.com/573400043/diff/549420043/lily/includable-lexer.cc#newcode74 lily/includable-lexer.cc:74: (current_dir.length () ? (current_dir ...
2 months, 2 weeks ago (2020-01-20 16:30:38 UTC) #1
Dan Eble
https://codereview.appspot.com/573400043/diff/549420043/lily/sources.cc File lily/sources.cc (right): https://codereview.appspot.com/573400043/diff/549420043/lily/sources.cc#newcode60 lily/sources.cc:60: Sources::find_full_path(string file_string, string const &current_dir) Is there any reason ...
2 months, 2 weeks ago (2020-01-21 13:42:28 UTC) #2
hanwenn
rebase; const
2 months, 2 weeks ago (2020-01-25 12:09:29 UTC) #3
hanwenn
https://codereview.appspot.com/573400043/diff/549420043/lily/sources.cc File lily/sources.cc (right): https://codereview.appspot.com/573400043/diff/549420043/lily/sources.cc#newcode60 lily/sources.cc:60: Sources::find_full_path(string file_string, string const &current_dir) On 2020/01/21 13:42:27, Dan ...
2 months, 2 weeks ago (2020-01-25 12:09:42 UTC) #4
hanwenn
compiling
2 months, 2 weeks ago (2020-01-26 14:12:37 UTC) #5
hanwenn
PTAL
2 months, 2 weeks ago (2020-01-26 14:13:39 UTC) #6
hanwenn
2 months, 2 weeks ago (2020-01-26 14:20:04 UTC) #7
fix compile error
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b