code review 57330043: runtime/debug: fix incorrect Stack output if package pa...

runtime/debug: fix incorrect Stack output if package path contains a dot

Although debug.Stack is deprecated, it should still return the correct result.
Output before this CL (using a trivial library in $GOPATH/test.com/a):
/home/vince/src/test.com/a/lib.go:9 (0x42311e)
        com/a.ShowStack: os.Stdout.Write(debug.Stack())

Output with this CL applied:
/home/vince/src/test.com/a/lib.go:9 (0x42311e)
        ShowStack: os.Stdout.Write(debug.Stack())

[vincent.vanackere, 2014-01-27 16:39:57]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[iant, 2014-01-27 17:18:59]

https://codereview.appspot.com/57330043/diff/40001/src/pkg/runtime/debug/stac...
File src/pkg/runtime/debug/stack.go (right):

https://codereview.appspot.com/57330043/diff/40001/src/pkg/runtime/debug/stac...
src/pkg/runtime/debug/stack.go:89: // we first remove the path prefix if there
is one
Please add a period at the end of the comment sentence.

[vincent.vanackere, 2014-01-27 21:00:17]

Hello golang-codereviews@googlegroups.com, iant@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[iant, 2014-01-27 21:56:27]

LGTM

[iant, 2014-01-27 22:00:09]

*** Submitted as https://code.google.com/p/go/source/detail?r=4e3be840c015 ***

runtime/debug: fix incorrect Stack output if package path contains a dot

Although debug.Stack is deprecated, it should still return the correct result.
Output before this CL (using a trivial library in $GOPATH/test.com/a):
/home/vince/src/test.com/a/lib.go:9 (0x42311e)
        com/a.ShowStack: os.Stdout.Write(debug.Stack())

Output with this CL applied:
/home/vince/src/test.com/a/lib.go:9 (0x42311e)
        ShowStack: os.Stdout.Write(debug.Stack())

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/57330043

Committer: Ian Lance Taylor <iant@golang.org>