Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(91)

Issue 573210043: Make has_interface work with a const Grob *

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by hahnjo
Modified:
1 week, 5 days ago
Reviewers:
Dan Eble, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make has_interface work with a const Grob * This required to change the predicate's type in the function Pointer_group_interface::find_grob and some follow-up adjustments. Other than that, I see no legitimate reason why this should not work.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Correct const modifier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M lily/bar-line.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/grob.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/grob-property.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/bar-line.hh View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/include/grob.hh View 1 3 chunks +3 lines, -3 lines 0 comments Download
M lily/include/grob-interface.hh View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/include/pointer-group-interface.hh View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/pointer-group-interface.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
lemzwerg
LGTM
1 week, 6 days ago (2019-11-04 18:59:23 UTC) #1
Dan Eble
This patch incites strong déjà vu. I've vaguely concerned that some status-quo uses of "const" ...
1 week, 6 days ago (2019-11-04 21:07:59 UTC) #2
hahnjo
Correct const modifier
1 week, 5 days ago (2019-11-05 18:34:25 UTC) #3
hahnjo
On 2019/11/04 21:07:59, Dan Eble wrote: > This patch incites strong déjà vu. I've vaguely ...
1 week, 5 days ago (2019-11-05 18:34:30 UTC) #4
hahnjo
https://codereview.appspot.com/573210043/diff/577070043/lily/grob-property.cc File lily/grob-property.cc (right): https://codereview.appspot.com/573210043/diff/577070043/lily/grob-property.cc#newcode183 lily/grob-property.cc:183: Grob *me = ((Grob *)this); On 2019/11/04 21:07:59, Dan ...
1 week, 5 days ago (2019-11-05 18:34:39 UTC) #5
Dan Eble
OK, go for it. I think focusing the commit headline on Pointer_group_interface::find_grob would hit the ...
1 week, 5 days ago (2019-11-05 19:21:03 UTC) #6
hahnjo
1 week, 5 days ago (2019-11-05 19:41:47 UTC) #7
On 2019/11/05 19:21:03, Dan Eble wrote:
> OK, go for it.
> 
> I think focusing the commit headline on Pointer_group_interface::find_grob
would
> hit the mark better.

The intention really is to make has_interface work, so I'd rather not. The
change to Pointer_group_interface::find_grob is just to avoid -fpermissive
warnings / errors because has_interface is passed as a predicate in one case.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b