Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 573150043: Fix 'check' target without tidy

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 2 days ago by hahnjo
Modified:
3 weeks, 1 day ago
Reviewers:
Dan Eble, lemzwerg, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

If configure didn't find tidy, it would assign an error message to the TIDY variable. Fix the logic of STEPMAKE_OPTIONAL_REQUIRED to leave a constant 'false' in the variable if an optional program is not found. This can be easily checked and has the advantage that it is guaranteed to fail if executed.

Patch Set 1 #

Patch Set 2 : Use 'false' as negative value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M GNUmakefile.in View 1 1 chunk +1 line, -1 line 0 comments Download
M aclocal.m4 View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7
lemzwerg
LGTM
3 weeks, 2 days ago (2019-10-25 17:05:20 UTC) #1
Dan Eble
Thanks for this. Seeing a warning message for an optional program bothered me, but addressing ...
3 weeks, 2 days ago (2019-10-25 20:10:08 UTC) #2
hahnjo
Use 'false' as negative value
3 weeks, 1 day ago (2019-10-26 08:48:40 UTC) #3
hahnjo
On 2019/10/25 20:10:08, Dan Eble wrote: > Thanks for this. Seeing a warning message for ...
3 weeks, 1 day ago (2019-10-26 08:51:34 UTC) #4
Dan Eble
On 2019/10/26 08:51:34, hahnjo wrote: > This is not about removing the warning message that ...
3 weeks, 1 day ago (2019-10-26 12:40:58 UTC) #5
Dan Eble
I don't have time right now to test that this still works when tidy is ...
3 weeks, 1 day ago (2019-10-26 14:57:32 UTC) #6
dak
3 weeks, 1 day ago (2019-10-26 16:52:51 UTC) #7
On 2019/10/26 14:57:32, Dan Eble wrote:
> I don't have time right now to test that this still works when tidy is
> installed, but since it's blocking others, I see no problem with pushing it to
> staging.

It's not just that there "is no problem".  Without working test procedures, the
state of this patch will not change to "push" anyway, so until testing gets
fixed, patches to fix patching cannot wait for testing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b