test of navigation changes

[shuehner, 2008-09-29 15:54:25]

short notes on unfinished changes

http://codereview.appspot.com/5731/diff/1/2
File src/org/openbravo/erpCommon/utility/DataGrid.java (right):

http://codereview.appspot.com/5731/diff/1/2#newcode188
Line 188: long s1 = System.currentTimeMillis();
debugging code, should be removed

http://codereview.appspot.com/5731/diff/1/2#newcode192
Line 192: log4j.error("strSql: " + strSQL);
debugging code, should be removed

http://codereview.appspot.com/5731/diff/1/2#newcode200
Line 200: long s2 = System.currentTimeMillis();
debugging code, should be removed

http://codereview.appspot.com/5731/diff/1/2#newcode202
Line 202: long e2 = System.currentTimeMillis();
debugging code, should be removed

http://codereview.appspot.com/5731/diff/1/2#newcode206
Line 206: long e3 = System.currentTimeMillis();
debugging code, should be removed

http://codereview.appspot.com/5731/diff/1/5
File src/org/openbravo/erpCommon/utility/ExecuteQuery.java (right):

http://codereview.appspot.com/5731/diff/1/5#newcode220
Line 220: public String[] selectSingleColumn() throws ServletException {
selectSingleColumn is not used and should be removed

http://codereview.appspot.com/5731/diff/1/5#newcode302
Line 302: long e1 = System.currentTimeMillis();
debugging, remove

http://codereview.appspot.com/5731/diff/1/5#newcode327
Line 327: long e2 = System.currentTimeMillis();
debugging, remove

http://codereview.appspot.com/5731/diff/1/4
File src/org/openbravo/erpCommon/utility/TableSQLData.java (right):

http://codereview.appspot.com/5731/diff/1/4#newcode240
Line 240: 
whitespace changes, remove

http://codereview.appspot.com/5731/diff/1/4#newcode249
Line 249: 
whitespace changes, remove

http://codereview.appspot.com/5731/diff/1/4#newcode265
Line 265: 
whitespace changes, remove

http://codereview.appspot.com/5731/diff/1/4#newcode269
Line 269: /**
more doc, link to other onlyId function

http://codereview.appspot.com/5731/diff/1/4#newcode1667
Line 1667: addInternalFilterField("(COALESCE(" + getTableName() + ".Processed,
'N')='N' OR " + getTableName() + ".Updated > sysdate-TO_NUMBER(?))", "FILTER");
figure out good way for pgsql&oracle

http://codereview.appspot.com/5731/diff/1/4#newcode1968
Line 1968: private static void printVector(String header, Vector<String> in) {
only for debugging -> remove

http://codereview.appspot.com/5731/diff/1/4#newcode1981
Line 1981: printVector("_FilterFields", _FilterFields);
only for debugging -> remove

http://codereview.appspot.com/5731/diff/1/4#newcode2009
Line 2009: // hardcoded clean...
remove, not used anymore

http://codereview.appspot.com/5731/diff/1/4#newcode2025
Line 2025: log4j.error("sql so far (after first from): " + text);
debugging

http://codereview.appspot.com/5731/diff/1/4#newcode2158
Line 2158: log4j.error("txtAuxWhere: " + txtAuxWhere);
document what this block does on higher level

[iperdomo, 2008-09-30 06:42:58]

My review is finished

http://codereview.appspot.com/5731/diff/1/5
File src/org/openbravo/erpCommon/utility/ExecuteQuery.java (right):

http://codereview.appspot.com/5731/diff/1/5#newcode162
Line 162: log4j.error("executeQuery took: " + (e1-s1));
Use log4j.debug() instead of error. We can leave it for performance testing

http://codereview.appspot.com/5731/diff/1/5#newcode303
Line 303: log4j.error("executeQuery took: " + (e1-s1));
Can we leave it as log4j.debug() ?

http://codereview.appspot.com/5731/diff/1/4
File src/org/openbravo/erpCommon/utility/TableSQLData.java (right):

http://codereview.appspot.com/5731/diff/1/4#newcode302
Line 302: //    if (log4j.isDebugEnabled()) log4j.debug("Subquery parameters
obtained");
Remove all commented code

[shuehner, 2009-12-06 11:40:53]

ivan.perdomo@openbravo.com wrote:
> http://codereview.appspot.com/5731
hmm?