Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(228)

Issue 5730044: Various fixes around hook execution and scheduling.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by hazmat
Modified:
10 years, 2 months ago
Reviewers:
jimbaker, mp+95706
Visibility:
Public.

Description

Various fixes around hook execution and scheduling. Fixed in this branch. - hook processes dying because of uncaught signals were being treated as though they had succeeded. - scheduler's that were started after stopped, would silently stop themselves because they didn't ignore the run queue stop marker value based on their current running status. - the expansion of joined events to multiple hook executions did not take into account the failure of a hook should stop executions. https://code.launchpad.net/~hazmat/juju/hook-alias-expansion-redux/+merge/95706 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Various fixes around hook execution and scheduling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -9 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M juju/errors.py View 1 1 chunk +8 lines, -3 lines 0 comments Download
M juju/hooks/invoker.py View 1 1 chunk +5 lines, -2 lines 0 comments Download
M juju/hooks/scheduler.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M juju/hooks/tests/hooks/sleep-hook View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M juju/hooks/tests/test_invoker.py View 1 1 chunk +13 lines, -0 lines 0 comments Download
M juju/hooks/tests/test_scheduler.py View 1 4 chunks +41 lines, -3 lines 0 comments Download
M juju/tests/test_errors.py View 1 1 chunk +6 lines, -0 lines 0 comments Download
M juju/unit/lifecycle.py View 1 2 chunks +4 lines, -1 line 0 comments Download
M juju/unit/tests/test_lifecycle.py View 1 4 chunks +41 lines, -0 lines 0 comments Download
M juju/unit/tests/test_workflow.py View 1 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 3
hazmat
Please take a look.
10 years, 2 months ago (2012-03-03 00:04:39 UTC) #1
jimbaker
LGTM, just a couple of trivial minors. I've also been through this code myself and ...
10 years, 2 months ago (2012-03-03 00:26:09 UTC) #2
hazmat
10 years, 2 months ago (2012-03-17 14:33:15 UTC) #3
*** Submitted:

Various fixes around hook execution and scheduling.

Fixed in this branch.

- hook processes dying because of uncaught signals were being 
  treated as though they had succeeded.

- scheduler's that were started after stopped, would silently stop themselves 
  because they didn't ignore the run queue stop marker value based on their 
  current running status.

- the expansion of joined events to multiple hook executions did not take into 
  account the failure of a hook should stop executions.

R=jimbaker
CC=
https://codereview.appspot.com/5730044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b