Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(388)

Issue 572520044: Fix #687: Include MIDI swing script in default distribution (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by Valentin Villenave
Modified:
4 months ago
Reviewers:
dak, thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix #687: Include MIDI swing script in default distribution This commit is based on Johannes Rohrer’s contribution, which in turn stemmed in part from other contributor’s work: https://sourceforge.net/p/testlilyissues/issues/687/?page=1&limit=25#c2cf (I haven’t contacted Johannes to ask for authorization; I assume we can safely distribute it under GPL like the rest of LilyPond. Full credit is given in the source code, and his many comments have all been preserved.) Documentation and regtest added, largely inspired by Peter Chubb’s articulate.ly script.

Patch Set 1 #

Total comments: 12

Patch Set 2 : More concise code with srfi-1 procedures #

Total comments: 3

Patch Set 3 : Further simplification; add CHANGES item. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+619 lines, -4 lines) Patch
M Documentation/changes.tely View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M Documentation/notation/input.itely View 1 2 3 chunks +109 lines, -4 lines 0 comments Download
A input/regression/swing-test.ly View 1 chunk +129 lines, -0 lines 0 comments Download
A ly/swing.ly View 1 2 1 chunk +361 lines, -0 lines 0 comments Download

Messages

Total messages: 7
thomasmorley651
Hi Valentin, up to now I didn't test, but read the code only. Several small ...
4 months, 1 week ago (2019-03-10 20:02:07 UTC) #1
Valentin Villenave
Thanks! I actually hadn’t reviewed Johannes’ code in detail, but you make good points. https://codereview.appspot.com/572520044/diff/574520044/ly/swing.ly ...
4 months, 1 week ago (2019-03-10 22:58:05 UTC) #2
Valentin Villenave
More concise code with srfi-1 procedures
4 months, 1 week ago (2019-03-10 22:58:20 UTC) #3
dak
https://codereview.appspot.com/572520044/diff/544550044/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/572520044/diff/544550044/Documentation/notation/input.itely#newcode246 Documentation/notation/input.itely:246: \paper @{ @dots{} @} I don't understand these diff ...
4 months, 1 week ago (2019-03-12 22:15:48 UTC) #4
Valentin Villenave
On 2019/03/12 22:15:48, dak wrote: > https://codereview.appspot.com/572520044/diff/544550044/Documentation/notation/input.itely#newcode246 > Documentation/notation/input.itely:246: \paper @{ @dots{} @} > I ...
4 months, 1 week ago (2019-03-13 08:51:34 UTC) #5
Valentin Villenave
Further simplification; add CHANGES item.
4 months, 1 week ago (2019-03-13 08:51:52 UTC) #6
Valentin Villenave
4 months ago (2019-03-18 18:59:11 UTC) #7
On 2019/03/13 08:51:52, Valentin Villenave wrote:
> Further simplification; add CHANGES item.

Pushed as
https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=464cf0d8111976c63fe...
Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b