store/lpload: trivial command to run PublishCharmsDistro

https://code.launchpad.net/~niemeyer/juju/go-store-lpload/+merge/95494

(do not edit description out of merge proposal)

[niemeyer, 2012-03-02 01:44:48]

Please take a look.

[rog, 2012-03-02 09:16:51]

LGTM with one minor remark.

https://codereview.appspot.com/5724043/diff/1/store/lpload/main.go
File store/lpload/main.go (right):

https://codereview.appspot.com/5724043/diff/1/store/lpload/main.go#newcode31
store/lpload/main.go:31: if _, ok := err.(store.PublishBranchErrors); !ok {
the comment is talking about the opposite case to the one it's actually dealing
with.

better, i think as:

 if _, ok := err.(store.PublishBranchErrors); ok {
      // Ignore branch errors since they're commonplace here.
      // They're logged, though.
     return nil
 }
 return err

[fwereade, 2012-03-02 17:03:38]

Otherwise LGTM

https://codereview.appspot.com/5724043/diff/1/store/lpload/main.go
File store/lpload/main.go (right):

https://codereview.appspot.com/5724043/diff/1/store/lpload/main.go#newcode31
store/lpload/main.go:31: if _, ok := err.(store.PublishBranchErrors); !ok {
On 2012/03/02 09:16:51, rog wrote:
> the comment is talking about the opposite case to the one it's actually
dealing
> with.
> 
> better, i think as:
> 
>  if _, ok := err.(store.PublishBranchErrors); ok {
>       // Ignore branch errors since they're commonplace here.
>       // They're logged, though.
>      return nil
>  }
>  return err

Seconded.

[niemeyer, 2012-03-02 18:07:33]

*** Submitted:

store/lpload: trivial command to run PublishCharmsDistro

R=rog, fwereade
CC=
https://codereview.appspot.com/5724043