Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3561)

Issue 5722045: store: added CharmEventKind.String

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by niemeyer
Modified:
12 years, 8 months ago
Reviewers:
mp+95498
Visibility:
Public.

Description

String representation is useful in logs, etc. https://code.launchpad.net/~niemeyer/juju/go-event-strings/+merge/95498 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : store: added CharmEventKind.String #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M store/store.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M store/store_test.go View 1 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5
niemeyer
Please take a look.
12 years, 8 months ago (2012-03-02 02:15:28 UTC) #1
rog
LGTM modulo the below https://codereview.appspot.com/5722045/diff/1/store/store.go File store/store.go (right): https://codereview.appspot.com/5722045/diff/1/store/store.go#newcode500 store/store.go:500: panic("unreachable") it's not actually unreachable ...
12 years, 8 months ago (2012-03-02 09:05:36 UTC) #2
fwereade
LGTM https://codereview.appspot.com/5722045/diff/1/store/store.go File store/store.go (right): https://codereview.appspot.com/5722045/diff/1/store/store.go#newcode500 store/store.go:500: panic("unreachable") On 2012/03/02 09:05:36, rog wrote: > it's ...
12 years, 8 months ago (2012-03-02 16:59:50 UTC) #3
niemeyer
https://codereview.appspot.com/5722045/diff/1/store/store.go File store/store.go (right): https://codereview.appspot.com/5722045/diff/1/store/store.go#newcode500 store/store.go:500: panic("unreachable") On 2012/03/02 16:59:51, fwereade wrote: > I dunno, ...
12 years, 8 months ago (2012-03-02 17:25:58 UTC) #4
niemeyer
12 years, 8 months ago (2012-03-02 18:23:46 UTC) #5
*** Submitted:

store: added CharmEventKind.String

String representation is useful in logs, etc.

R=rog, fwereade
CC=
https://codereview.appspot.com/5722045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b