Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1165)

Issue 572130043: Break substitution cleanup

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by hanwenn
Modified:
3 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Break substitution cleanup * Remove global var from break substitution This assumes that we don't need to be that conservative of stack space. This is reasonable because mutable properties and objects live in different alists these days, limiting the amount of recursion. * Remove some conditional checks that have no coverage in the regtest. * Always call do_break_processing(), moving the is_live check into spanner.cc

Patch Set 1 #

Patch Set 2 : rebase? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -30 lines) Patch
M lily/break-substitution.cc View 13 chunks +18 lines, -27 lines 0 comments Download
M lily/grob-array.cc View 3 chunks +36 lines, -0 lines 0 comments Download
M lily/include/grob-array.hh View 1 chunk +8 lines, -0 lines 0 comments Download
M lily/spanner.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/system.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1
hanwenn
3 months ago (2020-05-09 17:30:32 UTC) #1
rebase?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b