Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(755)

Issue 57210043: code review 57210043: api: add FreeBSD 10 exceptions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by mikio
Modified:
6 years, 10 months ago
Reviewers:
minux1, gobot
CC:
golang-codereviews, rsc, minux1, iant
Visibility:
Public.

Description

api: add FreeBSD 10 exceptions Update issue 7193

Patch Set 1 : diff -r abd51e52924a https://code.google.com/p/go #

Patch Set 2 : diff -r abd51e52924a https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r a3b2bc0b515e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M api/except.txt View 1 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 16
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
6 years, 10 months ago (2014-02-26 06:55:44 UTC) #1
mikio
Hello golang-codereviews@googlegroups.com, rsc@golang.org, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
6 years, 10 months ago (2014-02-27 15:49:39 UTC) #2
mikio
ping
6 years, 10 months ago (2014-03-02 01:32:36 UTC) #3
iant
My understanding is that only the values that are changing for good reason should be ...
6 years, 10 months ago (2014-03-02 19:16:55 UTC) #4
mikio
On 2014/03/02 19:16:55, iant wrote: > My understanding is that only the values that are ...
6 years, 10 months ago (2014-03-02 21:53:15 UTC) #5
mikio
On 2014/03/02 19:16:55, iant wrote: > New structs and new values should be in next.txt. ...
6 years, 10 months ago (2014-03-03 00:52:11 UTC) #6
iant
I didn't check every value, but there a couple of comments. https://codereview.appspot.com/57210043/diff/200001/api/except.txt File api/except.txt (right): ...
6 years, 10 months ago (2014-03-03 06:48:13 UTC) #7
mikio
Thanks. I forgot to say that these exceptions are just for applying CL 56770044. On ...
6 years, 10 months ago (2014-03-03 07:11:18 UTC) #8
minux1
On Sun, Mar 2, 2014 at 7:52 PM, <mikioh.mikioh@gmail.com> wrote: > On 2014/03/02 19:16:55, iant ...
6 years, 10 months ago (2014-03-03 08:38:00 UTC) #9
rsc
I would much rather list the differences than add some kind of wildcard for package ...
6 years, 10 months ago (2014-03-03 16:52:50 UTC) #10
mikio
I'm fine either way. minux? On Tue, Mar 4, 2014 at 1:50 AM, Russ Cox ...
6 years, 10 months ago (2014-03-03 17:34:43 UTC) #11
minux1
On Mon, Mar 3, 2014 at 12:34 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote: > I'm fine ...
6 years, 10 months ago (2014-03-03 19:30:48 UTC) #12
minux1
On Mar 3, 2014 11:52 AM, "Russ Cox" <rsc@golang.org> wrote: > I would much rather ...
6 years, 10 months ago (2014-03-03 19:31:26 UTC) #13
mikio
On Tue, Mar 4, 2014 at 4:30 AM, minux <minux.ma@gmail.com> wrote: > LGTM. I suggest ...
6 years, 10 months ago (2014-03-03 22:13:03 UTC) #14
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=c12c08ac4dc7 *** api: add FreeBSD 10 exceptions Update issue 7193 LGTM=minux.ma R=golang-codereviews, ...
6 years, 10 months ago (2014-03-04 00:26:35 UTC) #15
gobot
6 years, 10 months ago (2014-03-04 10:03:40 UTC) #16
Message was sent while issue was closed.
This CL appears to have broken the darwin-amd64-race-cheney builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b