Issue 5720051: store: fix length check in uniqueNameURLs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5720051: store: fix length check in uniqueNameURLs

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rog

Modified:
12 years, 2 months ago

Reviewers:
mp+95518

Visibility:
Public.

Description

I mentioned this in the review, but I think it must have been obscured by another suggestion I made in the same comment. https://code.launchpad.net/~rogpeppe/juju/go-store-fix-uniqueNameURLs/+merge/95518 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	store/lpad.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

12 years, 2 months ago (2012-03-02 18:28:08 UTC) #4

*** Submitted:

store: fix length check in uniqueNameURLs

I mentioned this in the review, but I think it must
have been obscured by another suggestion I made
in the same comment.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/5720051

Expand All Messages | Collapse All Messages