Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(870)

Issue 571780043: Issue 5806: Tweak mf files to avoid FontForge internal overlap error

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by Be-3
Modified:
4 months, 1 week ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5806: Tweak mf files to avoid FontForge internal overlap error When compiling LilyPond, there were 352 error messages caused by FontForge trying to resolve overlapping path problems: >>> Internal Error (overlap) in [...] Fortunately, the resulting glyphs had been OK, though. FontForge should be able to cope with this, but, alas, it isn't. I've now tweaked all the mf files causing these problems so that the annoying error messages can be avoided without while keeping the original resulting glyph outlines. modified: mf/feta-arrowheads.mf - former def_set_arrow_paths (returning both open_path and close_path) has been replaced by def_set_arrow_path returning one path arrow_path depending on additional boolean parameter CLOSED - No need to draw two overlapping mirrored half-paths anymore. - Char definitions adapted accordingly FIXES arrowheads.open.01 arrowheads.open.0M1 arrowheads.open.11 arrowheads.open.1M1 modified: mf/feta-braces.mf - now draw one single cyclic path rather than overlaying two separate, mirrored half-paths - using intersection and subpaths to exaclty retain the original slopes. FIXES brace4 - brace507 modified: mf/feta-clefs.mf - draw_gclef: just one control point changed (hidden in overlapping area) FIXES clefs.G clefs.GG clefs.tenorG - draw_tab_B: lower arc of the B in "TAB", angle slighty changed by 1° FIXES clefs.tab modified: mf/feta-numbers.mf - original paths in char definition re-arranged, intersected, joined, in order to create one single outline (two glyphs concerned): - two char definitions affected: FIXES two FIXES seven modified: mf/feta-scripts.mf - draw_turn: "ploop" overlay completely removed, using joined sub- paths instead FIXES scripts.reverseturn scripts.turn scripts.slashturn - "Segno" char definition: similar to draw_turn change FIXES scripts.segno modified: mf/feta-timesignatures.mf - draw_C: .. instead of -- (hidden in overlapping area) FIXES timesig.C44 timesig.C22 modified: mf/parmesan-clefs.mf - draw_neomensural_c_clef: .. instead of -- (hidden in overlap area) FIXES clefs.neomensural.c clefs.neomensural.c_change - draw_petrucci_c_clef: .. instead of .. (hidden in overlap area) FIXES clefs.petrucci.c1 clefs.petrucci.c2 clefs.petrucci.c2_change clefs.petrucci.c3 clefs.petrucci.c3_change clefs.petrucci.c4 clefs.petrucci.c5 clefs.petrucci.c5_change modified: mf/parmesan-rests.mf - "2neomensural" char definition: one additional auxiliary point inserted in overlap area FIXES rests.2neomensural >>> RESULT: same glyphs, no FontForge errors anymore

Patch Set 1 #

Total comments: 17

Patch Set 2 : Indentation and separating spaces #

Total comments: 1

Patch Set 3 : Indentation, 2nd attempt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -208 lines) Patch
M mf/feta-arrowheads.mf View 1 2 6 chunks +77 lines, -89 lines 0 comments Download
M mf/feta-braces.mf View 1 2 2 chunks +15 lines, -13 lines 0 comments Download
M mf/feta-clefs.mf View 2 chunks +2 lines, -2 lines 0 comments Download
M mf/feta-numbers.mf View 1 2 8 chunks +50 lines, -43 lines 0 comments Download
M mf/feta-scripts.mf View 1 2 3 chunks +43 lines, -48 lines 0 comments Download
M mf/feta-timesignatures.mf View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mf/parmesan-clefs.mf View 2 chunks +10 lines, -10 lines 0 comments Download
M mf/parmesan-rests.mf View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 9
Be-3
Please review.
4 months, 1 week ago (2020-02-29 09:20:49 UTC) #1
lemzwerg
Very nice, thanks! LGTM. https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf File mf/feta-arrowheads.mf (right): https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf#newcode58 mf/feta-arrowheads.mf:58: y5 = 0; Please use ...
4 months, 1 week ago (2020-02-29 17:23:40 UTC) #2
Be-3
Re-formatted: spaces inserted and strictly 8 char indentations. https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf File mf/feta-arrowheads.mf (right): https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf#newcode58 mf/feta-arrowheads.mf:58: y5 ...
4 months, 1 week ago (2020-03-01 04:33:28 UTC) #3
Be-3
Indentation and separating spaces
4 months, 1 week ago (2020-03-01 21:59:42 UTC) #4
Be-3
I think I forgot go mention that I now added Patch set 2: Indentation and ...
4 months, 1 week ago (2020-03-02 05:59:42 UTC) #5
lemzwerg
not happy with indentation yet... https://codereview.appspot.com/571780043/diff/549620043/mf/feta-scripts.mf File mf/feta-scripts.mf (left): https://codereview.appspot.com/571780043/diff/549620043/mf/feta-scripts.mf#oldcode999 mf/feta-scripts.mf:999: .. z2l > Nevertheless, ...
4 months, 1 week ago (2020-03-02 06:22:15 UTC) #6
Be-3
Indentation, 2nd attempt
4 months, 1 week ago (2020-03-02 10:44:00 UTC) #7
Be-3
OK, now I got it. Suppose I've erroneously treated these cases as broken line + ...
4 months, 1 week ago (2020-03-02 10:47:31 UTC) #8
lemzwerg
4 months, 1 week ago (2020-03-02 13:16:50 UTC) #9
LGTM, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b