ibus-setup: improve ibus-daemon auto start

ibus-setup: improve ibus-daemon auto start

Instead of repeatedly launch the daemon and wait, start it once and wait for
IBusBus::connected signal for 5 seconds.

BUG=none
TEST=manually on Fedora 17

[fujiwara, 2012-03-01 08:06:27]

On 2012/03/01 03:09:14, Daiki Ueno wrote:

Not sure why you're working on this while I take the responsibility.
The main problem is fixed and the patch looks ugly for me.
Personally I hope you cancel this patch.

[Daiki Ueno, 2012-03-01 08:18:51]

On 2012/03/01 08:06:27, fujiwara wrote:
> On 2012/03/01 03:09:14, Daiki Ueno wrote:
> 
> Not sure why you're working on this while I take the responsibility.
> The main problem is fixed and the patch looks ugly for me.
> Personally I hope you cancel this patch.

Hmm, I think this patch is still worth being considered.  It looks for me the
current code is rather ugly, because:

* IBus.Bus() call never raise exceptions so try...except and checking the return
value are not necessary at all
* I don't see any benefit of launching ibus-daemon multiple times.  Asking user
multiple times is generally not a good UI, IMHO

[Peng, 2012-03-01 14:29:13]

http://codereview.appspot.com/5716045/diff/1/setup/main.py
File setup/main.py (right):

http://codereview.appspot.com/5716045/diff/1/setup/main.py#newcode372
setup/main.py:372: self.__bus.connect('connected', connected_cb, main_loop)
I suggest using main_loop.quit or (lambda *args: main_loop.quit()) as callback
for those two function calls.

And then you may check bus.is_connected() after main_loop.run(), and then show
different dialogs and etc.

I think it can make function a little clearer.

[Daiki Ueno, 2012-03-02 01:07:11]

On 2012/03/01 14:29:13, Peng wrote:
> http://codereview.appspot.com/5716045/diff/1/setup/main.py
> File setup/main.py (right):
> 
> http://codereview.appspot.com/5716045/diff/1/setup/main.py#newcode372
> setup/main.py:372: self.__bus.connect('connected', connected_cb, main_loop)
> I suggest using main_loop.quit or (lambda *args: main_loop.quit()) as callback
> for those two function calls.
> 
> And then you may check bus.is_connected() after main_loop.run(), and then show
> different dialogs and etc.
> 
> I think it can make function a little clearer.

Yes, it certainly makes the logic easy to understand.  Fixed.

[Peng, 2012-03-02 05:17:20]

lgtm with one comment

https://codereview.appspot.com/5716045/diff/4001/setup/main.py
File setup/main.py (right):

https://codereview.appspot.com/5716045/diff/4001/setup/main.py#newcode325
setup/main.py:325: # self.__config.connect("value-changed",
self.__config_value_changed_cb)
Please remove those comment out code.