Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 5716045: ibus-setup: improve ibus-daemon auto start (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by Daiki Ueno
Modified:
3 years, 6 months ago
Reviewers:
shawn.p.huang, fujiwara
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ibus-setup: improve ibus-daemon auto start Instead of repeatedly launch the daemon and wait, start it once and wait for IBusBus::connected signal for 5 seconds. BUG=none TEST=manually on Fedora 17

Patch Set 1 #

Total comments: 1

Patch Set 2 : simplify connected/timeout callbacks #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -31 lines) Patch
M setup/main.py View 1 2 chunks +40 lines, -31 lines 1 comment Download

Messages

Total messages: 6
Daiki Ueno
3 years, 6 months ago (2012-03-01 03:09:14 UTC) #1
fujiwara
On 2012/03/01 03:09:14, Daiki Ueno wrote: Not sure why you're working on this while I ...
3 years, 6 months ago (2012-03-01 08:06:27 UTC) #2
Daiki Ueno
On 2012/03/01 08:06:27, fujiwara wrote: > On 2012/03/01 03:09:14, Daiki Ueno wrote: > > Not ...
3 years, 6 months ago (2012-03-01 08:18:51 UTC) #3
Peng
http://codereview.appspot.com/5716045/diff/1/setup/main.py File setup/main.py (right): http://codereview.appspot.com/5716045/diff/1/setup/main.py#newcode372 setup/main.py:372: self.__bus.connect('connected', connected_cb, main_loop) I suggest using main_loop.quit or (lambda ...
3 years, 6 months ago (2012-03-01 14:29:13 UTC) #4
Daiki Ueno
On 2012/03/01 14:29:13, Peng wrote: > http://codereview.appspot.com/5716045/diff/1/setup/main.py > File setup/main.py (right): > > http://codereview.appspot.com/5716045/diff/1/setup/main.py#newcode372 > ...
3 years, 6 months ago (2012-03-02 01:07:11 UTC) #5
Peng
3 years, 6 months ago (2012-03-02 05:17:20 UTC) #6
lgtm with one comment

https://codereview.appspot.com/5716045/diff/4001/setup/main.py
File setup/main.py (right):

https://codereview.appspot.com/5716045/diff/4001/setup/main.py#newcode325
setup/main.py:325: # self.__config.connect("value-changed",
self.__config_value_changed_cb)
Please remove those comment out code.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld fd993c8