Issue 5714054: allow <nav> element for jquery-1.7.1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5714054: allow <nav> element for jquery-1.7.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by felix8a

Modified:
14 years, 4 months ago

Reviewers:
Jasvir, metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

jquery-1.7.1 checks document.createElement('nav').cloneNode(true).outerHTML !== '<:nav></:nav>' to work around a bug in IE<=8, which returns that odd value. In caja, the createElement throws an error, so jquery fails to start. This change whitelists <nav>, which seems pretty harmless. jquery rationale: http://bugs.jquery.com/ticket/10501 http://bugs.jquery.com/ticket/10682 https://github.com/jquery/jquery/commit/41b31d7386cf00e714d703db773ffa73b6

Patch Set 1 #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -1 line)			Patch
M	src/com/google/caja/lang/html/html4-elements-extensions-defs.json	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	src/com/google/caja/lang/html/html4-elements-extensions-whitelist.json	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/domado.js	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

metaweta

lgtm. There was a message on the list a month or two ago about this; ...

14 years, 4 months ago (2012-03-01 15:39:35 UTC) #2

@r4798

Expand All Messages | Collapse All Messages