Issue 5714045: Whitelists input type=file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5714045: Whitelists input type=file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by metaweta

Modified:
14 years, 4 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	src/com/google/caja/lang/html/html4-attributes.json	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/com/google/caja/lang/html/HtmlSchemaTest.java	View		1 chunk	+0 lines, -4 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Jasvir

LGTM http://codereview.appspot.com/5714045/diff/1/tests/com/google/caja/lang/html/HtmlSchemaTest.java File tests/com/google/caja/lang/html/HtmlSchemaTest.java (left): http://codereview.appspot.com/5714045/diff/1/tests/com/google/caja/lang/html/HtmlSchemaTest.java#oldcode123 tests/com/google/caja/lang/html/HtmlSchemaTest.java:123: assertFalse(lookupAttribute("input", "type") Make these assertTrue instead?

14 years, 4 months ago (2012-03-01 00:38:53 UTC) #2

metaweta

14 years, 4 months ago (2012-03-01 00:55:33 UTC) #3

http://codereview.appspot.com/5714045/diff/1/tests/com/google/caja/lang/html/...
File tests/com/google/caja/lang/html/HtmlSchemaTest.java (left):

http://codereview.appspot.com/5714045/diff/1/tests/com/google/caja/lang/html/...
tests/com/google/caja/lang/html/HtmlSchemaTest.java:123:
assertFalse(lookupAttribute("input", "type")
On 2012/03/01 00:38:53, Jasvir wrote:
> Make these assertTrue instead?

Done.

Expand All Messages | Collapse All Messages