Issue 571280043: Encoding changes for Python 3

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 571280043: Encoding changes for Python 3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 4 months ago by hahnjo

Modified:
4 years, 2 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Encoding changes for Python 3 This is required to eventually make the scripts work with Python 3. The change happens to also work with Python 2.7 (and maybe also 2.6), but most certainly not with Python 2.5 or older supported up to now.

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -27 lines)			Patch
M	python/lilylib.py	View	4 chunks	+6 lines, -15 lines	0 comments	Download
M	python/midi.py	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	python/musicexp.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	python/musicxml.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	python/utilities.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	scripts/midi2ly.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/musicxml2ly.py	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hahnjo

4 years, 2 months ago (2020-01-22 09:19:34 UTC) #2

Closing as the change got smaller and smaller as I discovered more edge cases
where the current code matters with Python 2.x

Expand All Messages | Collapse All Messages