Update the proxy settings for the uniter process

Update the proxy settings for the uniter process

Some parts of the standard library functions can take
advantage of proxy settings when downloading things.
We should make sure that the agent process gets these
values too.

https://code.launchpad.net/~thumper/juju-core/uniter-set-osenv/+merge/203259

(do not edit description out of merge proposal)

[thumper, 2014-01-26 20:24:06]

Please take a look.

[dimitern, 2014-01-27 00:12:55]

LGTM. Is the uniter the only thing that might need the proxy settings? How about
the upgrader and deployer?

https://codereview.appspot.com/57110043/diff/1/juju/osenv/proxy.go
File juju/osenv/proxy.go (right):

https://codereview.appspot.com/57110043/diff/1/juju/osenv/proxy.go#newcode78
juju/osenv/proxy.go:78: //
Why both upper-case and lower-case?

[thumper, 2014-01-27 00:28:49]

On 2014/01/27 00:12:55, dimitern wrote:
> LGTM. Is the uniter the only thing that might need the proxy settings? How
about
> the upgrader and deployer?

I have a branch following that will add an environment watcher to the machine
agent.
We need a place to keep the files on disk correct, and it will also make sure
that
the environment settings for the process are good.

The golang net module will use the proxy settings if they are set.

> https://codereview.appspot.com/57110043/diff/1/juju/osenv/proxy.go
> File juju/osenv/proxy.go (right):
> 
> https://codereview.appspot.com/57110043/diff/1/juju/osenv/proxy.go#newcode78
> juju/osenv/proxy.go:78: //
> Why both upper-case and lower-case?

It seems to be historical. To the best of my knowledge most processes look for
the
lower-case versions, but unfortunately not all. Better to be safe and just set
both.

I would love to be proved wrong, but at this stage, it seems like the best
approach.