Issue 5703050: Ignore setLogFunc in ES5 in the playground

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5703050: Ignore setLogFunc in ES5 in the playground (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by Jasvir

Modified:
14 years, 2 months ago

Reviewers:
felix8a, metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

r4784 breaks ES5 in the playground. This change avoids calling setLogFunc in ES5 mode. @4796

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	src/com/google/caja/demos/playground/client/ui/PlaygroundView.java	View		1 chunk	+8 lines, -5 lines	0 comments	Download

Total messages: 3

metaweta

14 years, 3 months ago (2012-03-27 00:05:11 UTC) #3

On 2012/02/29 05:40:56, felix8a wrote:
> lgtm

please close