Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(520)

Issue 5702055: Go port for charm metadata support for subordinates

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by andrewsmedina
Modified:
9 years, 9 months ago
Reviewers:
niemeyer, mp+95082
Visibility:
Public.

Description

https://code.launchpad.net/~andrewsmedina/juju/go/+merge/95082 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Go port for charm metadata support for subordinates #

Total comments: 8

Patch Set 3 : Go port for charm metadata support for subordinates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -18 lines) Patch
M charm/meta.go View 1 2 7 chunks +44 lines, -6 lines 0 comments Download
M charm/meta_test.go View 1 2 3 chunks +35 lines, -12 lines 0 comments Download
A charm/testrepo/series/logging/metadata.yaml View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A charm/testrepo/series/logging/revision View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
andrewsmedina
Please take a look.
9 years, 9 months ago (2012-02-29 00:29:34 UTC) #1
andrewsmedina
Please take a look.
9 years, 9 months ago (2012-02-29 01:24:26 UTC) #2
niemeyer
Looks pretty good. Just a few minor details: https://codereview.appspot.com/5702055/diff/3001/charm/meta.go File charm/meta.go (right): https://codereview.appspot.com/5702055/diff/3001/charm/meta.go#newcode35 charm/meta.go:35: IsSubordinate ...
9 years, 9 months ago (2012-02-29 12:23:38 UTC) #3
andrewsmedina
Please take a look.
9 years, 9 months ago (2012-02-29 13:03:22 UTC) #4
niemeyer
LGTM, thanks!
9 years, 9 months ago (2012-02-29 13:07:19 UTC) #5
niemeyer
9 years, 9 months ago (2012-02-29 13:14:28 UTC) #6
*** Submitted:

charm: support subordinate and relation scope in metadata

R=niemeyer
CC=
https://codereview.appspot.com/5702055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b