Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(100)

Issue 5698077: Test document.all. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by MikeSamuel
Modified:
12 years, 11 months ago
Reviewers:
felix8a, Mark S. Miller
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

document.all is native object on IE such that document.all[x] is similar to document.getElementById(x). It is worth separate testing because Firefox supports it, but treats it specially so that: typeof document.all === "undefined" !!document.all so that feature detection code will take the no document.all path, but code that does not feature detect will continue to work in quirks mode: document.all.x is not a TypeError. It is in the square free shell which is in standards compliance mode. http://weblogs.mozillazine.org/asa/archives/007118.html explains: """ December 17, 2004 mozilla 1.7.5 released ... The new undetectable document.all support, and support for exposing elements by their ID in the global scope for greater IE compatibility when viewing pages that don't request standards compliant behaviour is documented in bugs 248549 and 256932. """

Patch Set 1 #

Patch Set 2 : Test document.all. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M tests/com/google/caja/plugin/es53-test-domado-special-guest.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-special-initial-state.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
MikeSamuel
14 years, 4 months ago (2012-02-27 17:59:59 UTC) #1
Mark S. Miller
See also https://bugzilla.mozilla.org/show_bug.cgi?id=521670 On Mon, Feb 27, 2012 at 9:59 AM, <mikesamuel@gmail.com> wrote: > Reviewers: ...
14 years, 4 months ago (2012-02-27 18:06:09 UTC) #2
MikeSamuel
2012/2/27 Mark S. Miller <erights@google.com>: > See also https://bugzilla.mozilla.org/show_bug.cgi?id=521670 Lovely. In ES6 there will be ...
14 years, 4 months ago (2012-02-27 18:59:06 UTC) #3
felix8a
domita_test is not run any more, and I have a pending CL that deletes it. ...
14 years, 4 months ago (2012-02-27 19:46:31 UTC) #4
MikeSamuel
On 2012/02/27 19:46:31, felix8a wrote: > domita_test is not run any more, and I have ...
14 years, 4 months ago (2012-02-27 22:58:54 UTC) #5
felix8a
14 years, 4 months ago (2012-02-27 23:50:42 UTC) #6
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b