Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(460)

Issue 5698073: ec2test: fix filtering behaviour.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by rog
Modified:
12 years, 1 month ago
Reviewers:
mp+94729
Visibility:
Public.

Description

Change the server so that DescribeInstances and DescribeSecurityGroups correctly give an error when asked to describe non-existent groups or instances. Also make group filtering understand more attributes, and update for recent gocheck changes. https://code.launchpad.net/~rogpeppe/goamz/ec2test-fix-filtering/+merge/94729 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : ec2test: fix filtering behaviour. #

Patch Set 3 : ec2test: fix filtering behaviour. #

Total comments: 6

Patch Set 4 : ec2test: fix filtering behaviour. #

Patch Set 5 : ec2test: fix filtering behaviour. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -281 lines) Patch
M ec2.go View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ec2_test.go View 1 2 3 20 chunks +99 lines, -99 lines 0 comments Download
M ec2i_test.go View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M ec2t_test.go View 1 2 3 13 chunks +231 lines, -87 lines 0 comments Download
M ec2test/filter.go View 1 2 3 2 chunks +3 lines, -51 lines 0 comments Download
M ec2test/server.go View 1 2 3 6 chunks +89 lines, -37 lines 0 comments Download

Messages

Total messages: 5
rog
Please take a look.
12 years, 1 month ago (2012-02-27 08:31:45 UTC) #1
niemeyer
LGTM https://codereview.appspot.com/5698073/diff/4001/ec2t_test.go File ec2t_test.go (right): https://codereview.appspot.com/5698073/diff/4001/ec2t_test.go#newcode537 ec2t_test.go:537: "", This table is very hard to read. ...
12 years, 1 month ago (2012-02-27 15:34:20 UTC) #2
rog
Please take a look.
12 years, 1 month ago (2012-02-27 16:09:42 UTC) #3
rog
PTAL https://codereview.appspot.com/5698073/diff/4001/ec2t_test.go File ec2t_test.go (right): https://codereview.appspot.com/5698073/diff/4001/ec2t_test.go#newcode537 ec2t_test.go:537: "", On 2012/02/27 15:34:20, niemeyer wrote: > This ...
12 years, 1 month ago (2012-02-27 16:12:23 UTC) #4
rog
12 years, 1 month ago (2012-02-27 16:16:29 UTC) #5
*** Submitted:

ec2test: fix filtering behaviour.

Change the server so that DescribeInstances
and DescribeSecurityGroups correctly give an error
when asked to describe non-existent groups or instances.

Also make group filtering understand more attributes,
and update for recent gocheck changes.

R=niemeyer
CC=
https://codereview.appspot.com/5698073
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b