Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(238)

Issue 5697074: fix getComputedStyle pseudo-element test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by felix8a
Modified:
14 years, 4 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

there's a getComputedStyle test looking for 'first-char', which is not a valid pseudo-element. this changes it to ':first-letter', and also adds a guard to skip the test on browsers that don't implement it correctly (chrome/safari).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M build.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 1 chunk +6 lines, -3 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-special-guest.html View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3
felix8a
14 years, 4 months ago (2012-02-27 14:20:57 UTC) #1
metaweta
lgtm
14 years, 4 months ago (2012-02-28 20:25:21 UTC) #2
felix8a
14 years, 4 months ago (2012-02-28 23:45:46 UTC) #3
@r4793
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b