Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(101)

Issue 569700043: Split glyph contours in up/down segments for skylines

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by hanwenn
Modified:
4 months, 3 weeks ago
Reviewers:
dak, lemzwerg, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Split glyph contours in up/down segments for skylines This reduces the amount of skyline input coming from glyph outlines by 2x. benchmark for arguments: input/regression/mozart-hrn-3 raw data: {'ff2061b518': [2.72, 2.69, 2.71], 'e8212e15e2': [2.7, 2.68, 2.69]} Version ff2061b518: Create skylines directly from glyph outlines. e8212e15e2 - Split glyph contours in up/down segments for skylines med diff -0.020000 med diff -0.738007 % (e8212e15e2 is faster) benchmark for arguments: -I carver MSDM raw data: {'ff2061b518': [51.83, 51.99, 52.05], 'e8212e15e2': [51.27, 51.2, 51.48]} ff2061b518: Create skylines directly from glyph outlines. e8212e15e2 - Split glyph contours in up/down segments for skylines med diff -0.720000 med diff -1.384882 % (e8212e15e2 is faster)

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : contours #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase; drop experimental work #

Total comments: 13

Patch Set 7 : jonas. #

Total comments: 3

Patch Set 8 : rebase on bugfix change #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -16 lines) Patch
M lily/freetype.cc View 1 2 3 4 5 6 7 4 chunks +9 lines, -4 lines 0 comments Download
M lily/include/lazy-skyline-pair.hh View 1 2 3 4 5 4 chunks +29 lines, -9 lines 1 comment Download
M lily/stencil-integral.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 20
hanwenn
goes on top of https://codereview.appspot.com/561730043/
5 months ago (2020-04-26 07:45:17 UTC) #1
hanwenn
rebase
5 months ago (2020-04-26 08:30:13 UTC) #2
hanwenn
contours
5 months ago (2020-04-26 11:20:31 UTC) #3
lemzwerg
LGTM
5 months ago (2020-05-01 19:37:54 UTC) #4
hanwenn
rebase
5 months ago (2020-05-02 07:36:05 UTC) #5
hanwenn
rebase
4 months, 3 weeks ago (2020-05-08 07:42:14 UTC) #6
hanwenn
rebase; drop experimental work
4 months, 3 weeks ago (2020-05-08 07:44:07 UTC) #7
hahnjo
https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc File lily/freetype.cc (right): https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode105 lily/freetype.cc:105: bool is_tt = (0 == strcmp ("TrueType", FT_Get_Font_Format (face))); ...
4 months, 3 weeks ago (2020-05-08 08:15:59 UTC) #8
hanwenn
jonas.
4 months, 3 weeks ago (2020-05-08 14:03:21 UTC) #9
hanwenn
https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc File lily/freetype.cc (right): https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode105 lily/freetype.cc:105: bool is_tt = (0 == strcmp ("TrueType", FT_Get_Font_Format (face))); ...
4 months, 3 weeks ago (2020-05-08 14:03:23 UTC) #10
hahnjo
On 2020/05/08 14:03:23, hanwenn wrote: > https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode162 > lily/freetype.cc:162: } > On 2020/05/08 08:15:59, hahnjo ...
4 months, 3 weeks ago (2020-05-08 14:14:47 UTC) #11
hanwenn
On Fri, May 8, 2020 at 4:14 PM <jonas.hahnfeld@gmail.com> wrote: > > On 2020/05/08 14:03:23, ...
4 months, 3 weeks ago (2020-05-08 14:20:36 UTC) #12
dak
On 2020/05/08 14:14:47, hahnjo wrote: > assert(false) that none of the previous cases was true? ...
4 months, 3 weeks ago (2020-05-08 14:24:18 UTC) #13
hahnjo
On 2020/05/08 14:24:18, dak wrote: > On 2020/05/08 14:14:47, hahnjo wrote: > > > assert(false) ...
4 months, 3 weeks ago (2020-05-08 14:28:56 UTC) #14
hanwenn
On Fri, May 8, 2020 at 4:28 PM <jonas.hahnfeld@gmail.com> wrote: > > seems to make ...
4 months, 3 weeks ago (2020-05-08 14:43:49 UTC) #15
lemzwerg
[forgot to send it previously] https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc File lily/freetype.cc (right): https://codereview.appspot.com/569700043/diff/582060043/lily/freetype.cc#newcode126 lily/freetype.cc:126: else if (outline->tags[j] & ...
4 months, 3 weeks ago (2020-05-08 15:44:56 UTC) #16
lemzwerg
https://codereview.appspot.com/569700043/diff/573820043/lily/freetype.cc File lily/freetype.cc (right): https://codereview.appspot.com/569700043/diff/573820043/lily/freetype.cc#newcode129 lily/freetype.cc:129: else if (ctags[j] & 1) 1 → FT_CURVE_TAG_ON https://codereview.appspot.com/569700043/diff/573820043/lily/freetype.cc#newcode137 ...
4 months, 3 weeks ago (2020-05-08 15:49:18 UTC) #17
hanwenn
On 2020/05/08 15:49:18, lemzwerg wrote: > https://codereview.appspot.com/569700043/diff/573820043/lily/freetype.cc > File lily/freetype.cc (right): > > https://codereview.appspot.com/569700043/diff/573820043/lily/freetype.cc#newcode129 > ...
4 months, 3 weeks ago (2020-05-10 08:40:14 UTC) #18
hanwenn
rebase on bugfix change
4 months, 3 weeks ago (2020-05-10 09:08:39 UTC) #19
hahnjo
4 months, 3 weeks ago (2020-05-10 09:18:49 UTC) #20
https://codereview.appspot.com/569700043/diff/554040049/lily/include/lazy-sky...
File lily/include/lazy-skyline-pair.hh (right):

https://codereview.appspot.com/569700043/diff/554040049/lily/include/lazy-sky...
lily/include/lazy-skyline-pair.hh:30: CW  = UP,
whitespace formatting?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b