Issue 5696063: Get jQuery UI "Draggable" working

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5696063: Get jQuery UI "Draggable" working (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by ihab.awad

Modified:
14 years, 4 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Get jQuery UI "Draggable" working #

Patch Set 3 : Get jQuery UI "Draggable" working #

Patch Set 4 : Get jQuery UI "Draggable" working #

Total comments: 2

Patch Set 5 : Get jQuery UI "Draggable" working #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -60 lines)			Patch
M	src/com/google/caja/demos/playground/client/ui/Example.java	View		1 chunk	+3 lines, -1 line	0 comments	Download
D	src/com/google/caja/demos/playground/examples/datepicker.html	View		1 chunk	+0 lines, -39 lines	0 comments	Download
A +	src/com/google/caja/demos/playground/examples/jquery-datepicker.html	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
A	src/com/google/caja/demos/playground/examples/jquery-draggable.html	View	1 2 3	1 chunk	+39 lines, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/bridal.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/plugin/domado.js	View	1 2 3 4	5 chunks	+8 lines, -13 lines	0 comments	Download
M	tests/com/google/caja/plugin/es53-test-domado-dom-guest.html	View	1 2 3 4	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

ihab.awad

This change renames 'datepicker.html' to 'jquery-datepicker.html'. I'm not sure why this fact is not being ...

14 years, 4 months ago (2012-02-24 21:54:01 UTC) #3

Jasvir

LGTM++ http://codereview.appspot.com/5696063/diff/5002/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): http://codereview.appspot.com/5696063/diff/5002/src/com/google/caja/plugin/domado.js#newcode1139 src/com/google/caja/plugin/domado.js:1139: makeDOMAccessible(element.currentStyle); Can you replace this with a call ...

14 years, 4 months ago (2012-02-24 22:20:59 UTC) #6

@4787

Expand All Messages | Collapse All Messages