Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1260)

Issue 5695061: Simplify font building.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by joeneeman
Modified:
12 years, 2 months ago
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Simplify font building. Gets rid of intermediate .lisp files, and doesn't build tables except for the braces. Build emmentaler with python instead of pe.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -429 lines) Patch
M configure.in View 1 1 chunk +9 lines, -0 lines 1 comment Download
M mf/GNUmakefile View 7 chunks +9 lines, -85 lines 0 comments Download
A python/mf_table.py View 1 1 chunk +184 lines, -0 lines 0 comments Download
A scripts/build/gen-emmentaler.py View 1 1 chunk +105 lines, -0 lines 0 comments Download
D scripts/build/gen-emmentaler-scripts.py View 1 chunk +0 lines, -108 lines 0 comments Download
M scripts/build/mf-to-table.py View 1 chunk +13 lines, -236 lines 0 comments Download

Messages

Total messages: 10
lemzwerg
LGTM.
12 years, 2 months ago (2012-02-25 07:22:00 UTC) #1
Julien Rioux
This adds a dependency on the python module fontforge. I think it should be checked ...
12 years, 2 months ago (2012-02-25 12:44:23 UTC) #2
hanwenn
haven't looked in detail, but nice, and simpler than I thought :) now, if you ...
12 years, 2 months ago (2012-02-25 12:57:09 UTC) #3
Julien Rioux
This is good, I now get the error message right away when running configure. No ...
12 years, 2 months ago (2012-02-25 15:57:55 UTC) #4
Graham Percival
On Sat, Feb 25, 2012 at 03:57:55PM +0000, julien.rioux@gmail.com wrote: > This is good, I ...
12 years, 2 months ago (2012-02-25 16:23:43 UTC) #5
c_sorensen
On 2/25/12 9:23 AM, "Graham Percival" <graham@percival-music.ca> wrote: >On Sat, Feb 25, 2012 at 03:57:55PM ...
12 years, 2 months ago (2012-02-25 16:50:33 UTC) #6
Graham Percival
On Sat, Feb 25, 2012 at 04:50:21PM +0000, Carl Sorensen wrote: > On 2/25/12 9:23 ...
12 years, 2 months ago (2012-02-25 17:01:00 UTC) #7
joeneeman
On Sat, Feb 25, 2012 at 8:23 AM, Graham Percival <graham@percival-music.ca>wrote: > On Sat, Feb ...
12 years, 2 months ago (2012-02-25 22:06:46 UTC) #8
Graham Percival
On Sat, Feb 25, 2012 at 02:06:46PM -0800, Joe Neeman wrote: > On Sat, Feb ...
12 years, 2 months ago (2012-02-25 22:18:09 UTC) #9
hanwenn
12 years, 2 months ago (2012-02-27 12:15:04 UTC) #10
On Sat, Feb 25, 2012 at 8:06 PM, Joe Neeman <joeneeman@gmail.com> wrote:
> On Sat, Feb 25, 2012 at 8:23 AM, Graham Percival <graham@percival-music.ca>
> wrote:
>>
>> On Sat, Feb 25, 2012 at 03:57:55PM +0000, julien.rioux@gmail.com wrote:
>> > This is good, I now get the error message right away when running
>> > configure. No problem with the patch after installing the required
>> > package. Do lilydev and gub already include the fontforge python
>> > package?
>>
>> No, and adding this to GUB will be particularly challenging.  I'm
>> afraid that this will probably postpone the patch indefinitely.
>> :(
>
>
> Why would it be particularly challenging? In fact, since GUB builds
> fontforge, the python bindings may already be included (I'm attempting to
> check this now). It's just that debian-like distros feel the need to
> separate each package into 5 pieces...

It would be cleaner to change to build fontforge as a python extension
only, then we don't need to worry about graphic toolkits and such.

-- 
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b