Issue 569340043: Remove unused ly_hash_scm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 569340043: Remove unused ly_hash_scm (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 2 months ago by hanwenn

Modified:
4 years, 2 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Remove unused ly_hash_scm

Patch Set 1 #

Patch Set 2 : dak #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	lily/include/lily-guile.hh	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
	M	lily/lily-guile.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dak

Issue title is wrong. Function is ly_scm_hash, not ly_hash_scm. Also its prototype in lily/include/lily-guile.hh should ...

4 years, 2 months ago (2020-02-13 12:05:51 UTC) #1

hanwenn

On 2020/02/13 12:05:51, dak wrote: > Issue title is wrong. Function is ly_scm_hash, not ly_hash_scm. ...

4 years, 2 months ago (2020-02-15 17:09:42 UTC) #3

hanwenn

4 years, 2 months ago (2020-02-19 09:36:28 UTC) #4

commit 7cf2dd486822a301ae36928790cfcd81154be449
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Thu Feb 13 11:28:14 2020 +0100

    Remove unused ly_scm_hash
    
    https://sourceforge.net/p/testlilyissues/issues/5755
    http://codereview.appspot.com/569340043

Expand All Messages | Collapse All Messages