Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(459)

Issue 5693051: Remove sid parameter from UserKey constructor. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by thakis
Modified:
1 year, 1 month ago
CC:
rlz-codereviews_googlegroups.com
Base URL:
http://rlz.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Remove sid parameter from UserKey constructor. All callers pass in NULL now anyway. Committed: https://code.google.com/p/rlz/source/detail?r=65

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -44 lines) Patch
M win/lib/financial_ping.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M win/lib/rlz_lib.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M win/lib/user_key.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M win/lib/user_key.cc View 1 1 chunk +10 lines, -25 lines 0 comments Download

Messages

Total messages: 4
thakis
Note that this one is not TBR :-)
12 years, 3 months ago (2012-02-23 19:13:11 UTC) #1
Roger Tawa (Google)
https://codereview.appspot.com/5693051/diff/1/win/lib/user_key.cc File win/lib/user_key.cc (right): https://codereview.appspot.com/5693051/diff/1/win/lib/user_key.cc#newcode19 win/lib/user_key.cc:19: // No SID is specified, so the caller is ...
12 years, 3 months ago (2012-02-23 19:51:59 UTC) #2
thakis
https://codereview.appspot.com/5693051/diff/1/win/lib/user_key.cc File win/lib/user_key.cc (right): https://codereview.appspot.com/5693051/diff/1/win/lib/user_key.cc#newcode19 win/lib/user_key.cc:19: // No SID is specified, so the caller is ...
12 years, 3 months ago (2012-02-23 20:11:05 UTC) #3
Roger Tawa (Google)
12 years, 3 months ago (2012-02-23 20:37:47 UTC) #4
lgtm

Yes I think this can be made smaller in a follow up CL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b