Issue 5693051: Remove sid parameter from UserKey constructor.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5693051: Remove sid parameter from UserKey constructor. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by thakis

Modified:
1 year, 7 months ago

Reviewers:
Roger Tawa, Roger Tawa (Google)

CC:
rlz-codereviews_googlegroups.com

Base URL:
http://rlz.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove sid parameter from UserKey constructor. All callers pass in NULL now anyway. Committed: https://code.google.com/p/rlz/source/detail?r=65

Patch Set 2 : comments #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -44 lines)			Patch
M	win/lib/financial_ping.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	win/lib/rlz_lib.cc	View		10 chunks	+10 lines, -10 lines	0 comments	Download
M	win/lib/user_key.h	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	win/lib/user_key.cc	View	1	1 chunk	+10 lines, -25 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Roger Tawa (Google)

https://codereview.appspot.com/5693051/diff/1/win/lib/user_key.cc File win/lib/user_key.cc (right): https://codereview.appspot.com/5693051/diff/1/win/lib/user_key.cc#newcode19 win/lib/user_key.cc:19: // No SID is specified, so the caller is ...

12 years, 9 months ago (2012-02-23 19:51:59 UTC) #2

thakis

12 years, 9 months ago (2012-02-23 20:11:05 UTC) #3

Roger Tawa (Google)

12 years, 9 months ago (2012-02-23 20:37:47 UTC) #4

lgtm

Yes I think this can be made smaller in a follow up CL.

Expand All Messages | Collapse All Messages