Issue 5691043: Reenables cajaVM.log in playground.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5691043: Reenables cajaVM.log in playground. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by metaweta

Modified:
14 years, 4 months ago

Reviewers:
Jasvir, ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Reenables cajaVM.log in playground. #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -7 lines)			Patch
	M	src/com/google/caja/demos/playground/client/ui/PlaygroundView.java	View	1	4 chunks	+19 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ihab.awad

lgtm++ http://codereview.appspot.com/5691043/diff/1/src/com/google/caja/demos/playground/client/ui/PlaygroundView.java File src/com/google/caja/demos/playground/client/ui/PlaygroundView.java (right): http://codereview.appspot.com/5691043/diff/1/src/com/google/caja/demos/playground/client/ui/PlaygroundView.java#newcode499 src/com/google/caja/demos/playground/client/ui/PlaygroundView.java:499: that.@com.google.caja.demos.playground.client.ui.PlaygroundView::addRuntimeMessage(Ljava/lang/String;) We should think of what the risk ...

14 years, 4 months ago (2012-02-23 00:31:52 UTC) #2

metaweta

14 years, 4 months ago (2012-02-23 00:33:59 UTC) #3

http://codereview.appspot.com/5691043/diff/1/src/com/google/caja/demos/playgr...
File src/com/google/caja/demos/playground/client/ui/PlaygroundView.java (right):

http://codereview.appspot.com/5691043/diff/1/src/com/google/caja/demos/playgr...
src/com/google/caja/demos/playground/client/ui/PlaygroundView.java:499:
that.@com.google.caja.demos.playground.client.ui.PlaygroundView::addRuntimeMessage(Ljava/lang/String;)
On 2012/02/23 00:31:53, ihab.awad wrote:
> We should think of what the risk is, if any, if the error contains HTML,
> including <script>s. Either way, I think this needs a comment explaining the
> reasoning.

Done.

Expand All Messages | Collapse All Messages