Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(254)

Issue 568970043: Add user-definable ottavation markups

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 2 weeks ago by Malte Meyn
Modified:
1 month, 1 week ago
Reviewers:
kieren_macmillan
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add user-definable ottavation markups The context property ottavationMarkups is an alist containing markups for different octaves. Entries 22ma, 29ma, 22mb, and 29mb were added. There is a warning when \ottava uses a number of octaves that has no corresponding markup (alist entry). Contains regtest

Patch Set 1 #

Total comments: 2

Patch Set 2 : change default ottavationMarkups, adapt regtest, fix ambitus regression #

Patch Set 3 : correct line lengths #

Patch Set 4 : change default again (to simple numbers, bold series) #

Total comments: 1

Patch Set 5 : make bassa ordinals end on va/ma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -9 lines) Patch
A input/regression/ottavation-markups.ly View 1 1 chunk +30 lines, -0 lines 0 comments Download
M lily/ambitus-engraver.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ly/engraver-init.ly View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-context-properties.scm View 1 chunk +3 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-music-callbacks.scm View 1 chunk +7 lines, -7 lines 0 comments Download
M scm/translation-functions.scm View 1 2 3 4 2 chunks +39 lines, -1 line 0 comments Download

Messages

Total messages: 11
Malte Meyn
https://codereview.appspot.com/568970043/diff/551000043/scm/define-music-callbacks.scm File scm/define-music-callbacks.scm (right): https://codereview.appspot.com/568970043/diff/551000043/scm/define-music-callbacks.scm#newcode87 scm/define-music-callbacks.scm:87: (ly:warning "Could not find ottavation markup for ~a octaves ...
1 month, 2 weeks ago (2019-09-27 08:57:35 UTC) #1
Malte Meyn
https://codereview.appspot.com/568970043/diff/551000043/ly/engraver-init.ly File ly/engraver-init.ly (right): https://codereview.appspot.com/568970043/diff/551000043/ly/engraver-init.ly#newcode107 ly/engraver-init.ly:107: ottavationMarkups = Should we change the defaults to something ...
1 month, 2 weeks ago (2019-09-30 19:51:43 UTC) #2
kieren_macmillan_sympatico.ca
Hi all, > https://codereview.appspot.com/568970043/diff/551000043/ly/engraver-init.ly#newcode107 > ly/engraver-init.ly:107: ottavationMarkups = > Should we change the defaults to ...
1 month, 2 weeks ago (2019-09-30 20:00:29 UTC) #3
Malte Meyn
On 2019/09/30 20:00:29, kieren_macmillan_sympatico.ca wrote: > I’m happy to submit a [regular markup] version for ...
1 month, 2 weeks ago (2019-10-01 15:21:43 UTC) #4
Malte Meyn
change default ottavationMarkups, adapt regtest, fix ambitus regression
1 month, 2 weeks ago (2019-10-01 15:56:21 UTC) #5
Malte Meyn
correct line lengths
1 month, 2 weeks ago (2019-10-01 15:59:19 UTC) #6
Malte Meyn
change default again (to simple numbers, bold series)
1 month, 1 week ago (2019-10-02 08:23:53 UTC) #7
Malte Meyn
On 2019/10/02 08:23:53, Malte Meyn wrote: > change default again (to simple numbers, bold series) ...
1 month, 1 week ago (2019-10-02 08:30:24 UTC) #8
Malte Meyn
https://codereview.appspot.com/568970043/diff/547000043/scm/translation-functions.scm File scm/translation-functions.scm (right): https://codereview.appspot.com/568970043/diff/547000043/scm/translation-functions.scm#newcode909 scm/translation-functions.scm:909: (3 . "22") I’ll correct this indentation with the ...
1 month, 1 week ago (2019-10-02 08:36:33 UTC) #9
Malte Meyn
make bassa ordinals end on va/ma
1 month, 1 week ago (2019-10-02 11:11:25 UTC) #10
Malte Meyn
1 month, 1 week ago (2019-10-02 11:12:08 UTC) #11
On 2019/10/02 11:11:25, Malte Meyn wrote:
> make bassa ordinals end on va/ma

Not for #ottava-simple-ordinals for compatibility reasons. But who wants to use
that anyway? ;)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b